Skip to content

Conversation

abhinaykukkadapu
Copy link
Contributor

Summary: quantize_() modifies model in place, we need to make a copy to avoid making changes to user passed model. Fix a bug as discussed in #14171 (comment)

Differential Revision: D82167495

Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14186

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 Cancelled Jobs

As of commit 9f12495 with merge base f294074 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82167495

abhinaykukkadapu added a commit to abhinaykukkadapu/executorch that referenced this pull request Sep 10, 2025
…ge (pytorch#14186)

Summary:

`quantize_()` modifies model in place, we need to make a copy to avoid making changes to user passed model. Fix a bug as discussed in pytorch#14171 (comment)

Differential Revision: D82167495
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82167495

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ge (pytorch#14186)

Summary:

`quantize_()` modifies model in place, we need to make a copy to avoid making changes to user passed model. Fix a bug as discussed in pytorch#14171 (comment)

Differential Revision: D82167495
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D82167495

@metascroy
Copy link
Contributor

LGTM

@abhinaykukkadapu abhinaykukkadapu merged commit 8a0a25b into pytorch:main Sep 11, 2025
119 of 126 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants