Skip to content

Allow PUBLIC visibility and make it the default #14181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

Allow PUBLIC visibility and make it the default #14181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14b2bb6
Update
swolchok Sep 10, 2025
1decdae
Update
swolchok Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shim_et/xplat/executorch/build/runtime_wrapper.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def _patch_kwargs_common(kwargs):
# don't pick up unexpected clients while things are still in flux.
if not kwargs.pop("_is_external_target", False):
for target in kwargs.get("visibility", []):
if not (target.startswith("//executorch") or target.startswith("//pytorch/tokenizers") or target.startswith("@")):
if not (target == "PUBLIC" or target.startswith("//executorch") or target.startswith("//pytorch/tokenizers") or target.startswith("@")):
fail("Please manage all external visibility using the " +
"EXECUTORCH_CLIENTS list in " +
"//executorch/build/fb/clients.bzl. " +
Expand All @@ -199,7 +199,7 @@ def _patch_kwargs_common(kwargs):
env.patch_deps(kwargs, dep_type)

if "visibility" not in kwargs:
kwargs["visibility"] = ["//executorch/..."]
kwargs["visibility"] = ["PUBLIC"]

# Patch up references to "//executorch/..." in lists of build targets,
# if necessary.
Expand Down
Loading