Skip to content

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Sep 10, 2025

IMO we don't have a particular reason to lock down visibility by default.

Differential Revision: D82156686

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14181

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 4 Unrelated Failures

As of commit 1decdae with merge base 53b7ec5 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[ghstack-poisoned]
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@swolchok
Copy link
Contributor Author

@swolchok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 06362f3 into main Sep 11, 2025
112 of 119 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/568/head branch September 11, 2025 16:28
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82156686

Pull Request resolved: pytorch#14181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants