Optionally disable debug handle validateion #14182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14182
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 Cancelled Jobs, 2 Unrelated FailuresAs of commit 69074bc with merge base 8358516 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81784685 |
This PR needs a
|
Gasoonjia
approved these changes
Sep 10, 2025
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Sep 10, 2025
Summary: Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
kimishpatel
force-pushed
the
export-D81784685
branch
from
3c7caea to
19699ab
Compare
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Sep 10, 2025
Summary: Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
kimishpatel
force-pushed
the
export-D81784685
branch
from
19699ab to
3763bfc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81784685 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D81784685 |
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Sep 10, 2025
Summary: Pull Request resolved: pytorch#14182 Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
kimishpatel
force-pushed
the
export-D81784685
branch
from
3763bfc to
8f45d31
Compare
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Sep 11, 2025
Summary: Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
kimishpatel
force-pushed
the
export-D81784685
branch
from
8f45d31 to
b244bf8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81784685 |
kimishpatel
force-pushed
the
export-D81784685
branch
from
b244bf8 to
07b9861
Compare
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Sep 11, 2025
Summary: Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
|
This pull request was exported from Phabricator. Differential Revision: D81784685 |
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Sep 11, 2025
Summary: Pull Request resolved: pytorch#14182 Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
kimishpatel
force-pushed
the
export-D81784685
branch
from
07b9861 to
0d06750
Compare
kimishpatel
added a commit
to kimishpatel/executorch-1
that referenced
this pull request
Sep 11, 2025
Summary: Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
kimishpatel
force-pushed
the
export-D81784685
branch
from
0d06750 to
dca2ec8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81784685 |
Summary: Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc., during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This flag allows one to override such behavior and make best effort comparison. Reviewed By: Gasoonjia Differential Revision: D81784685
kimishpatel
force-pushed
the
export-D81784685
branch
from
dca2ec8 to
69074bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D81784685 |
swolchok
added a commit
that referenced
this pull request
Sep 12, 2025
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
Differential Revision: D81784685 Pull Request resolved: pytorch#14182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Often when aten graph has symbolic shape nodes, and inbuilt ops like gt/lt etc.,
during re-export of such a graph 'from_node' information is lost from node.meta. As a result we loose connection
between edge IR nodes and aten nodes for such ops. By default we validate that every edge IR node has corresponding
node in aten IR, and when such validation fails numeric debugger falls back to edge IR as reference graph. This
flag allows one to override such behavior and make best effort comparison.
Reviewed By: Gasoonjia
Differential Revision: D81784685