Skip to content

Conversation

swolchok
Copy link
Contributor

This reverts commit 378c700 (#14182). It broke unittest / windows.

[ghstack-poisoned]
@swolchok swolchok requested a review from Gasoonjia as a code owner September 12, 2025 20:09
@swolchok
Copy link
Contributor Author

swolchok commented Sep 12, 2025

Stack from ghstack (oldest at bottom):

@pytorch-bot pytorch-bot bot added the ci-no-td label Sep 12, 2025
Copy link

pytorch-bot bot commented Sep 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14281

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

swolchok added a commit that referenced this pull request Sep 12, 2025
This reverts commit 378c700 (#14182). It broke unittest / windows.


ghstack-source-id: 715d9ce
ghstack-comment-id: 3286690859
Pull-Request: #14281
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@swolchok
Copy link
Contributor Author

fix is already landing

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@swolchok swolchok closed this Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant