Revert "Update default executor runner with new optional options" #14193

mergennachin · 2025-09-11T01:42:23Z

https://www.internalfb.com/diff/D82053273

Here's the error from internal failure

executorch/extension/runner_util/inputs.cpp:118:13: error: format specifies type 'long' but the argument has type 'std::tuple_element<1, std::pair<char *, unsigned int>>::type' (aka 'unsigned int') [-Werror,-Wformat]
    [CONTEXT]   117 |             "input size (%ld) and tensor size (%ld) mismatch!",
    [CONTEXT]       |                          ~~~
    xplat/executorch/extension/runner_util/inputs.cpp:119:13: error: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
    [CONTEXT]   117 |             "input size (%ld) and tensor size (%ld) mismatch!",
    [CONTEXT]       |                                                ~~~
    xplat/executorch/extension/runner_util/inputs.cpp:118:13: error: format specifies type 'long' but the argument has type 'std::tuple_element<1, std::pair<char *, unsigned int>>::type' (aka 'unsigned int') [-Werror,-Wformat]
    [CONTEXT]   117 |             "input size (%ld) and tensor size (%ld) mismatch!",
    [CONTEXT]       |                          ~~~
    xplat/executorch/extension/runner_util/inputs.cpp:119:13: error: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
    [CONTEXT]   117 |             "input size (%ld) and tensor size (%ld) mismatch!",
    [CONTEXT]       |       
	
	


executorch/extension/runner_util/inputs.cpp:118:13: error: format specifies type 'long' but the argument has type 'std::tuple_element<1, std::pair<char *, unsigned int>>::type' (aka 'unsigned int') [-Werror,-Wformat]
    [CONTEXT]   117 |             "input size (%ld) and tensor size (%ld) mismatch!",
    [CONTEXT]       |                          ~~~
    [CONTEXT]       |                          %u
    [CONTEXT]   118 |             buffer_size,
    [CONTEXT]       |             ^~~~~~~~~~~
    [CONTEXT] xplat/executorch/runtime/platform/log.h:181:13: note: expanded from macro 'ET_LOG'
    [CONTEXT]   180 |           _format,                                                   \
    [CONTEXT]       |           ~~~~~~~
    [CONTEXT]   181 |           ##__VA_ARGS__);                                            \
    [CONTEXT]       |             ^~~~~~~~~~~
    xplat/executorch/extension/runner_util/inputs.cpp:119:13: error: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat]
    [CONTEXT]   117 |             "input size (%ld) and tensor size (%ld) mismatch!",
    [CONTEXT]       |                                                ~~~
    [CONTEXT]       |                                                %zu
    [CONTEXT]   118 |             buffer_size,
    [CONTEXT]   119 |             tensor_meta->nbytes());
    [CONTEXT]       |             ^~~~~~~~~~~~~~~~~~~~~
    [CONTEXT] xplat/executorch/runtime/platform/log.h:181:13: note: expanded from macro 'ET_LOG'
    [CONTEXT]   180 |           _format,                                                   \
    [CONTEXT]       |           ~~~~~~~
    [CONTEXT]   181 |           ##__VA_ARGS__);                                            \
    [CONTEXT]       |             ^~~~~~~~~~~
    [CONTEXT] 2 errors generated.

)" This reverts commit 16aac24.

pytorch-bot · 2025-09-11T01:42:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14193

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 105 Pending

As of commit 6ddfcbe with merge base 53b7ec5 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions · 2025-09-11T01:43:03Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ytorch#14193) This reverts commit dc190f9. Original PR, pytorch#14017 was reverted by pytorch#14193. This reverts the revert. The only difference from the original PR is fixing a printf format mismatch in inputs.cpp: %ld is changed to %zu. This should compile on both 32- and 64-bit ABIs. Change-Id: If487e6c6bde313844a94db99a7431af33dfcdd0a

…torch#14193) Reverts pytorch#14017 https://www.internalfb.com/diff/D82053273 Here's the error from internal failure ``` executorch/extension/runner_util/inputs.cpp:118:13: error: format specifies type 'long' but the argument has type 'std::tuple_element<1, std::pair<char *, unsigned int>>::type' (aka 'unsigned int') [-Werror,-Wformat] [CONTEXT] 117 | "input size (%ld) and tensor size (%ld) mismatch!", [CONTEXT] | ~~~ xplat/executorch/extension/runner_util/inputs.cpp:119:13: error: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat] [CONTEXT] 117 | "input size (%ld) and tensor size (%ld) mismatch!", [CONTEXT] | ~~~ xplat/executorch/extension/runner_util/inputs.cpp:118:13: error: format specifies type 'long' but the argument has type 'std::tuple_element<1, std::pair<char *, unsigned int>>::type' (aka 'unsigned int') [-Werror,-Wformat] [CONTEXT] 117 | "input size (%ld) and tensor size (%ld) mismatch!", [CONTEXT] | ~~~ xplat/executorch/extension/runner_util/inputs.cpp:119:13: error: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat] [CONTEXT] 117 | "input size (%ld) and tensor size (%ld) mismatch!", [CONTEXT] | executorch/extension/runner_util/inputs.cpp:118:13: error: format specifies type 'long' but the argument has type 'std::tuple_element<1, std::pair<char *, unsigned int>>::type' (aka 'unsigned int') [-Werror,-Wformat] [CONTEXT] 117 | "input size (%ld) and tensor size (%ld) mismatch!", [CONTEXT] | ~~~ [CONTEXT] | %u [CONTEXT] 118 | buffer_size, [CONTEXT] | ^~~~~~~~~~~ [CONTEXT] xplat/executorch/runtime/platform/log.h:181:13: note: expanded from macro 'ET_LOG' [CONTEXT] 180 | _format, \ [CONTEXT] | ~~~~~~~ [CONTEXT] 181 | ##__VA_ARGS__); \ [CONTEXT] | ^~~~~~~~~~~ xplat/executorch/extension/runner_util/inputs.cpp:119:13: error: format specifies type 'long' but the argument has type 'size_t' (aka 'unsigned int') [-Werror,-Wformat] [CONTEXT] 117 | "input size (%ld) and tensor size (%ld) mismatch!", [CONTEXT] | ~~~ [CONTEXT] | %zu [CONTEXT] 118 | buffer_size, [CONTEXT] 119 | tensor_meta->nbytes()); [CONTEXT] | ^~~~~~~~~~~~~~~~~~~~~ [CONTEXT] xplat/executorch/runtime/platform/log.h:181:13: note: expanded from macro 'ET_LOG' [CONTEXT] 180 | _format, \ [CONTEXT] | ~~~~~~~ [CONTEXT] 181 | ##__VA_ARGS__); \ [CONTEXT] | ^~~~~~~~~~~ [CONTEXT] 2 errors generated. ```

Revert "Update default executor runner with new optional options (#14017

6ddfcbe

)" This reverts commit 16aac24.

mergennachin requested review from swolchok, larryliu0820, manuelcandales and digantdesai as code owners September 11, 2025 01:42

pytorch-bot bot added the ci-no-td label Sep 11, 2025

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2025

kirklandsign approved these changes Sep 11, 2025

View reviewed changes

mergennachin merged commit dc190f9 into main Sep 11, 2025
113 of 122 checks passed

mergennachin deleted the revert-14017-vkml branch September 11, 2025 02:05

mansnils mentioned this pull request Sep 11, 2025

Reapply "Update default executor runner with new optional options" #14207

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Revert "Update default executor runner with new optional options" #14193

Revert "Update default executor runner with new optional options" #14193

Uh oh!

mergennachin commented Sep 11, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Sep 11, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 11, 2025

Uh oh!

Uh oh!

Uh oh!

Revert "Update default executor runner with new optional options" #14193

Revert "Update default executor runner with new optional options" #14193

Uh oh!

Conversation

mergennachin commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14193

⏳ No Failures, 105 Pending

Uh oh!

github-actions bot commented Sep 11, 2025

This PR needs a release notes: label

Uh oh!

Uh oh!

Uh oh!

mergennachin commented Sep 11, 2025 •

edited

Loading

pytorch-bot bot commented Sep 11, 2025 •

edited

Loading

This PR needs a `release notes:` label