Skip to content

Conversation

mansnils
Copy link
Collaborator

@mansnils mansnils commented Sep 11, 2025

This reverts commit dc190f9.

Original PR, #14017 was reverted by #14193.

This reverts the revert. The only difference from the original PR is fixing a printf format mismatch in inputs.cpp: %ld is changed to %zu. This should compile on both 32- and 64-bit ABIs.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

…ytorch#14193)

This reverts commit dc190f9.

Original PR, pytorch#14017 was
reverted by pytorch#14193.

This reverts the revert. The only difference from the original PR is
fixing a printf format mismatch in inputs.cpp: %ld is changed to %zu.
This should compile on both 32- and 64-bit ABIs.

Change-Id: If487e6c6bde313844a94db99a7431af33dfcdd0a
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Sep 11, 2025
Copy link

pytorch-bot bot commented Sep 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14207

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 1 Cancelled Job, 8 Unrelated Failures

As of commit 1ad66ee with merge base 6ed10e5 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 11, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D82212827.

@mergennachin mergennachin self-requested a review September 11, 2025 11:50
@zingo zingo added this to the 1.0.0 milestone Sep 11, 2025
@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D82212827.

@mergennachin
Copy link
Contributor

Another failure

Stdout: <empty>
Stderr:
xplat/executorch/examples/portable/executor_runner/executor_runner.cpp:350:14: error: unused variable 'written_size' [-Werror,-Wunused-variable]
  350 |         auto written_size =
      |              ^~~~~~~~~~~~
1 error generated.

Action sub-errors produced by error handlers:
- [cxx_unused_variable]

@mansnils
Copy link
Collaborator Author

Another failure

Stdout: <empty>
Stderr:
xplat/executorch/examples/portable/executor_runner/executor_runner.cpp:350:14: error: unused variable 'written_size' [-Werror,-Wunused-variable]
  350 |         auto written_size =
      |              ^~~~~~~~~~~~
1 error generated.

Action sub-errors produced by error handlers:
- [cxx_unused_variable]

Done

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D82212827.

@facebook-github-bot
Copy link
Contributor

@mergennachin has imported this pull request. If you are a Meta employee, you can view this in D82212827.

@facebook-github-bot facebook-github-bot merged commit 7f49d4f into pytorch:main Sep 11, 2025
294 of 303 checks passed
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82212827

Pull Request resolved: pytorch#14207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants