Qualcomm AI Engine Direct - add seq_mse_candidates setting to SmolLM3 and fixed a bug in the graph drawer #14295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and fixed a bug in the graph drawer
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14295
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Cancelled JobAs of commit 11e794c with merge base eec95d0 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@pytorchbot label "release notes: qualcomm" |
pytorch-bot
bot
added
the
release notes: qualcomm
cccclai
reviewed
Sep 15, 2025
| ptq = QuantDtype.use_16a4w_block | ||
| group_size = 32 | ||
| masked_softmax = True | ||
| seq_mse_candidates = 0 |
There was a problem hiding this comment.
What does 0 seq_mse_candidates mean
There was a problem hiding this comment.
Thanks for asking the question about seq_mse_candidates setting.
Setting seq_mse_candidates = 0 means that SeqMSE is disabled during quantization.
For more details, can refer:
https://github.com/pytorch/executorch/blob/main/examples/qualcomm/oss_scripts/llama/decoder_utils.py#L367-L375
cccclai
approved these changes
Sep 16, 2025
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
… and fixed a bug in the graph drawer (pytorch#14295) Qualcomm AI Engine Direct - add seq_mse_candidates setting to SmolLM3 and fixed a bug in the graph drawer ### Summary - add seq_mse_candidates setting to SmolLM3 - fixed a bug in the graph drawer ### Test plan DrawGraph Unit test ``` bash python -m backends.qualcomm.tests.test_qnn_delegate TestQNNFloatingPointUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL} -b build-android -a . --executorch_root . python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL} -b build-android -a . --executorch_root . ``` SmolLM3 script in `./examples/qualcomm/oss_scripts/llama/README.md` at SmolLM3 part
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 25, 2025
… and fixed a bug in the graph drawer (#14295) Qualcomm AI Engine Direct - add seq_mse_candidates setting to SmolLM3 and fixed a bug in the graph drawer ### Summary - add seq_mse_candidates setting to SmolLM3 - fixed a bug in the graph drawer ### Test plan DrawGraph Unit test ``` bash python -m backends.qualcomm.tests.test_qnn_delegate TestQNNFloatingPointUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL} -b build-android -a . --executorch_root . python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL} -b build-android -a . --executorch_root . ``` SmolLM3 script in `./examples/qualcomm/oss_scripts/llama/README.md` at SmolLM3 part (cherry picked from commit d61dbb9)
Cherry picking #14295The cherry pick PR is at #14571 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
|
This PR fixes the bug in the config for smolLM3 and should be included in release/1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qualcomm AI Engine Direct - add seq_mse_candidates setting to SmolLM3 and fixed a bug in the graph drawer
Summary
Test plan
DrawGraph Unit test
SmolLM3
script in
./examples/qualcomm/oss_scripts/llama/README.mdat SmolLM3 part