Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Qualcomm AI Engine Direct - add seq_mse_candidates setting to SmolLM3 and fixed a bug in the graph drawer

Summary

  • add seq_mse_candidates setting to SmolLM3
  • fixed a bug in the graph drawer

Test plan

DrawGraph Unit test

python -m backends.qualcomm.tests.test_qnn_delegate TestQNNFloatingPointUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL}  -b build-android -a . --executorch_root .
python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL}  -b build-android -a . --executorch_root .

SmolLM3
script in ./examples/qualcomm/oss_scripts/llama/README.md at SmolLM3 part

… and fixed a bug in the graph drawer (#14295)

Qualcomm AI Engine Direct - add seq_mse_candidates setting to SmolLM3
and fixed a bug in the graph drawer
### Summary
 - add seq_mse_candidates setting to SmolLM3
 - fixed a bug in the graph drawer

### Test plan
DrawGraph Unit test
``` bash
python -m backends.qualcomm.tests.test_qnn_delegate TestQNNFloatingPointUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL}  -b build-android -a . --executorch_root .
python -m backends.qualcomm.tests.test_qnn_delegate TestQNNQuantizedUtils.test_qnn_backend_draw_graph -s ${SERIAL_NUM} -m ${SOC_MODEL}  -b build-android -a . --executorch_root .
```
SmolLM3
script in `./examples/qualcomm/oss_scripts/llama/README.md` at SmolLM3
part

(cherry picked from commit d61dbb9)
Copy link

pytorch-bot bot commented Sep 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14571

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 17a8ec7 with merge base e0dda90 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
@DannyYuyang-quic
Copy link
Contributor

Hi @cccclai, this PR(#14295) fixes the bug in the config for smolLM3 and should be included in release/1.0
Without this fix, an error will occur during smolLM3 model compilation.

@GregoryComer GregoryComer merged commit 57e469c into release/1.0 Sep 26, 2025
132 of 139 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14295-by-pytorch_bot_bot_ branch September 26, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants