Skip to content

Remove LlavaRunner #14356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

Remove LlavaRunner #14356

merged 1 commit into from
Sep 17, 2025

Conversation

rohansjoshi
Copy link
Contributor

Summary

Following up on #14250, remove LlavaRunner (and llava_runner library dependency)

Test plan

Llava CI test

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14356

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 10 Pending

As of commit acd3365 with merge base 108d29d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2025
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign
Copy link
Contributor

executorch/extension/android/jni/BUCK

Line 116 in 108d29d

"//xplat/executorch/examples/models/llava/runner:runner_static",

@kirklandsign
Copy link
Contributor

Remove https://github.com/pytorch/executorch/pull/14356/files#diff-6cfdc4894f08602902337ade7d271ab292754ef664107aa216ac6f30350c48d5R173-L176

@rohansjoshi rohansjoshi merged commit 9c12e69 into main Sep 17, 2025
126 checks passed
@rohansjoshi rohansjoshi deleted the remove-llava-runner branch September 17, 2025 01:04
@kirklandsign kirklandsign mentioned this pull request Sep 17, 2025
Merged
StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
@rohansjoshi @StrycekSimon
Remove LlavaRunner (pytorch#14356)
5503464 
### Summary
Following up on
[pytorch#14250](pytorch#14250), remove
LlavaRunner (and llava_runner library dependency)

### Test plan
Llava CI test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@kirklandsign kirklandsign kirklandsign approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohansjoshi @kirklandsign @larryliu0820