Skip to content

Remove LlavaRunner #14356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2025
Merged

Remove LlavaRunner #14356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions examples/models/llava/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,7 @@ list(APPEND CMAKE_FIND_ROOT_PATH ${CMAKE_CURRENT_BINARY_DIR}/../../..)
find_package(executorch CONFIG REQUIRED FIND_ROOT_PATH_BOTH)
executorch_target_link_options_shared_lib(executorch)

# llava_runner library
add_subdirectory(runner)

set(LINK_LIBS executorch gflags)
set(LINK_LIBS executorch gflags extension_llm_runner)
set(link_libraries ${LINK_LIBS})
set(_srcs main.cpp)

Expand Down Expand Up @@ -204,5 +201,5 @@ if(NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
endif()

target_include_directories(llava_main PUBLIC ${_common_include_directories})
target_link_libraries(llava_main PUBLIC llava_runner ${link_libraries})
target_link_libraries(llava_main PUBLIC ${link_libraries})
target_compile_options(llava_main PUBLIC ${_common_compile_options})
46 changes: 0 additions & 46 deletions examples/models/llava/runner/CMakeLists.txt
View file
Open in desktop

This file was deleted.

107 changes: 0 additions & 107 deletions examples/models/llava/runner/llava_image_prefiller.h
View file
Open in desktop

This file was deleted.

191 changes: 0 additions & 191 deletions examples/models/llava/runner/llava_runner.cpp
View file
Open in desktop

This file was deleted.

Loading
Loading