-
Notifications
You must be signed in to change notification settings - Fork 680
Back out "Improve asset management" #14383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Original commit changeset: 46d2f763787b Original Phabricator Diff: D80715432 Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840). From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists." FB app has also seen an increase in error code 0x23 since 9/5. We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve. Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps: * In diff 1/3, we backout D81256207, which added more logging * In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert * In diff 3/3, we introduce some of the logging we backed out in diff 1/3 Differential Revision: D82581443
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14383
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 6 Cancelled JobsAs of commit 3ca0e64 with merge base 75cb986 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581443. |
This PR needs a
|
@metascroy is this cherry-picked on the release branch? |
Differential Revision: D82581443 Pull Request resolved: pytorch#14383
@pytorchbot cherry-pick --onto release/1.0 -c critical |
I don't think it needs to be b/c the OSS version has no issues. But I'll go ahead a cherry pick anyway |
Cherry picking #14383The cherry pick PR is at #14569 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Summary:
Original commit changeset: 46d2f763787b
Original Phabricator Diff: D80715432
Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps:
Differential Revision: D82581443