Skip to content

Conversation

metascroy
Copy link
Contributor

@metascroy metascroy commented Sep 17, 2025

Summary:
Original commit changeset: 46d2f763787b

Original Phabricator Diff: D80715432

Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps:

  • In diff 1/3, we backout D81256207, which added more logging
  • In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
  • In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Differential Revision: D82581443

Summary:
Original commit changeset: 46d2f763787b

Original Phabricator Diff: D80715432

Since the introduction of D80715432, WhatsApp is seeing an increase in model load failures with error code 0x23 (P1948468840).  From logs, the underlying issue is something like "Model init failed “model.mlmodelc” couldn’t be moved to “models” because an item with the same name already exists."

FB app has also seen an increase in error code 0x23 since 9/5.
We are unable to reproduce this error locally, but out of caution we want to revert D80715432 and see if the errors resolve.

Since D80715432 landed, we also landed D81256207 to add more logging.  To prevent conflicts, we backout in 3 steps:
* In diff 1/3, we backout D81256207, which added more logging
* In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
* In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Differential Revision: D82581443
Copy link

pytorch-bot bot commented Sep 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14383

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 6 Cancelled Jobs

As of commit 3ca0e64 with merge base 75cb986 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2025
@facebook-github-bot
Copy link
Contributor

@metascroy has exported this pull request. If you are a Meta employee, you can view the originating diff in D82581443.

Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@facebook-github-bot facebook-github-bot merged commit 82c1d77 into pytorch:main Sep 18, 2025
280 of 295 checks passed
@shoumikhin
Copy link
Contributor

@metascroy is this cherry-picked on the release branch?

StrycekSimon pushed a commit to nxp-upstream/executorch that referenced this pull request Sep 23, 2025
Differential Revision: D82581443

Pull Request resolved: pytorch#14383
@metascroy
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/1.0 -c critical

@metascroy
Copy link
Contributor Author

@metascroy is this cherry-picked on the release branch?

I don't think it needs to be b/c the OSS version has no issues. But I'll go ahead a cherry pick anyway

pytorchbot pushed a commit that referenced this pull request Sep 25, 2025
Differential Revision: D82581443

Pull Request resolved: #14383

(cherry picked from commit 82c1d77)
@pytorchbot
Copy link
Collaborator

Cherry picking #14383

The cherry pick PR is at #14569 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

GregoryComer pushed a commit that referenced this pull request Sep 26, 2025
Differential Revision: D82581443

Pull Request resolved: #14383

(cherry picked from commit 82c1d77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants