Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Summary:
Original commit changeset: 46d2f763787b

Original Phabricator Diff: D80715432

Since D80715432 landed, we also landed D81256207 to add more logging. To prevent conflicts, we backout in 3 steps:

  • In diff 1/3, we backout D81256207, which added more logging
  • In diff 2/3, we backout D80715432, which is the problematic diff we're trying to revert
  • In diff 3/3, we introduce some of the logging we backed out in diff 1/3

Differential Revision: D82581443

Copy link

pytorch-bot bot commented Sep 25, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14569

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 11 Pending

As of commit a297261 with merge base e0dda90 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 25, 2025
Differential Revision: D82581443

Pull Request resolved: #14383

(cherry picked from commit 82c1d77)
@GregoryComer GregoryComer force-pushed the cherry-pick-14383-by-pytorch_bot_bot_ branch from 201e236 to 2383201 Compare September 26, 2025 20:58
@GregoryComer
Copy link
Member

Manually rebasing as there are some minor merge conflicts in ETCoreMLModelManager.mm. Hopefully low risk as conflicts were mainly comments. I double-checked and this specific pick PR is ordered properly with the reverts on main branch. If CI passes, I'll merge.

@GregoryComer GregoryComer merged commit 4c6717e into release/1.0 Sep 29, 2025
122 of 129 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14383-by-pytorch_bot_bot_ branch September 29, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants