ExecutorchRuntimeException: Update the exception return type #14483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix the JNI layer at the time of throwing the exception. Change the return type from 'ExecutorchRuntimeException' to 'RuntimeException' Also disable readLogBuffer from exception flow , A follow up change will address this. This way it keeps this change to a minimum and unblocks few Teams for now Differential Revision: D82995994
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14483
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit ed0ad47 with merge base c9f46e2 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
GregoryComer
approved these changes
Sep 22, 2025
psiddh
force-pushed
the
export-D82995994
branch
from
59922bd to
ed0ad47
Compare
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 23, 2025
Summary: Fix the JNI layer at the time of throwing the exception. Change the return type from 'ExecutorchRuntimeException' to 'RuntimeException' Also disable readLogBuffer from exception flow , A follow up change will address this. This way it keeps this change to a minimum and unblocks few Teams for now Differential Revision: D82995994 (cherry picked from commit 00ea1b7)
Cherry picking #14483The cherry pick PR is at #14498 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
StrycekSimon
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Sep 23, 2025
…#14483) Summary: Fix the JNI layer at the time of throwing the exception. Change the return type from 'ExecutorchRuntimeException' to 'RuntimeException' Also disable readLogBuffer from exception flow , A follow up change will address this. This way it keeps this change to a minimum and unblocks few Teams for now Differential Revision: D82995994
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the JNI layer at the time of throwing the exception. Change the return type from 'ExecutorchRuntimeException' to 'RuntimeException'
Also disable readLogBuffer from exception flow , A follow up change will address this. This way it keeps this change to a minimum and unblocks few Teams for now
Differential Revision: D82995994