Skip to content

ExecutorchRuntimeException: Update the exception return type #14483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

ExecutorchRuntimeException: Update the exception return type #14483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5912bfd
ExecutorchRuntimeException: Update the exception return type
psiddh Sep 22, 2025
ed0ad47
Merge branch 'pytorch:main' into export-D82995994
psiddh Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions ...d/executorch_android/src/main/java/org/pytorch/executorch/ExecutorchRuntimeException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ public class ExecutorchRuntimeException extends RuntimeException {
}

static class ErrorHelper {
private static final boolean ENABLE_READ_LOG_BUFFER = false;
// Reusable StringBuilder instance
private static final StringBuilder sb = new StringBuilder();

Expand All @@ -92,14 +93,15 @@ static String formatMessage(int errorCode, String details) {
.append("] ")
.append(baseMessage)
.append(": ")
.append(details)
.append("\nDetailed Logs:\n");

try {
String[] logEntries = readLogBuffer(); // JNI call
formatLogEntries(sb, logEntries);
} catch (Exception e) {
sb.append("Failed to retrieve detailed logs: ").append(e.getMessage());
.append(details);
if (ENABLE_READ_LOG_BUFFER) {
try {
sb.append("\nDetailed Logs:\n");
String[] logEntries = readLogBuffer(); // JNI call
formatLogEntries(sb, logEntries);
} catch (Exception e) {
sb.append("Failed to retrieve detailed logs: ").append(e.getMessage());
}
}

return sb.toString();
Expand Down
11 changes: 6 additions & 5 deletions extension/android/jni/jni_helper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ void throwExecutorchException(uint32_t errorCode, const std::string& details) {
"org/pytorch/executorch/ExecutorchRuntimeException");

// Find the static factory method: makeExecutorchException(int, String)
static auto makeExceptionMethod = exceptionClass->getStaticMethod<
facebook::jni::local_ref<facebook::jni::JThrowable>(
int, facebook::jni::alias_ref<facebook::jni::JString>)>(
"makeExecutorchException",
"(ILjava/lang/String;)Lorg/pytorch/executorch/ExecutorchRuntimeException;");
static auto makeExceptionMethod =
exceptionClass
->getStaticMethod<facebook::jni::local_ref<facebook::jni::JThrowable>(
int, facebook::jni::alias_ref<facebook::jni::JString>)>(
"makeExecutorchException",
"(ILjava/lang/String;)Ljava/lang/RuntimeException;");

auto jDetails = facebook::jni::make_jstring(details);
// Call the factory method to create the exception object
Expand Down
Loading