Skip to content

Conversation

Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Oct 8, 2025

PR #14861 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

PR pytorch#14861 introduced the NAMED_DATA_MAP extension which
is required to be on when BUILD_EXTENSION_MODULE is on.
Therefore, turn it on where needed.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Change-Id: I34f7cc989e7369883b353d96ccb262b43062a82f
Copy link

pytorch-bot bot commented Oct 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14885

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Unrelated Failure

As of commit e1cfee8 with merge base fb87fa6 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2025
@Erik-Lundell Erik-Lundell added ciflow/trunk partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 8, 2025
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2025
@zingo
Copy link
Collaborator

zingo commented Oct 8, 2025

Fails unrelated

@zingo zingo merged commit 45bf018 into pytorch:main Oct 8, 2025
379 of 390 checks passed
@zingo
Copy link
Collaborator

zingo commented Oct 8, 2025

@pytorchbot cherry-pick --onto release/1.0 -c critical

pytorchbot pushed a commit that referenced this pull request Oct 8, 2025
PR #14861 introduced the NAMED_DATA_MAP extension which is required to
be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where
needed.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
(cherry picked from commit 45bf018)
@pytorchbot
Copy link
Collaborator

Cherry picking #14885

The cherry pick PR is at #14907 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

zingo pushed a commit that referenced this pull request Oct 9, 2025
Missed updating docs in #14885

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
pytorchbot pushed a commit that referenced this pull request Oct 9, 2025
Missed updating docs in #14885

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
(cherry picked from commit 29b98c3)
mergennachin pushed a commit that referenced this pull request Oct 9, 2025
Missed updating docs in #14885

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Co-authored-by: Erik Lundell <erik.lundell@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants