-
Notifications
You must be signed in to change notification settings - Fork 686
Arm backend: build with NAMED_DATA_MAP=ON for vgf #14885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR pytorch#14861 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed. Signed-off-by: Erik Lundell <erik.lundell@arm.com> Change-Id: I34f7cc989e7369883b353d96ccb262b43062a82f
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14885
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 1 Unrelated FailureAs of commit e1cfee8 with merge base fb87fa6 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Fails unrelated |
@pytorchbot cherry-pick --onto release/1.0 -c critical |
Cherry picking #14885The cherry pick PR is at #14907 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Missed updating docs in #14885 Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Missed updating docs in #14885 cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Erik Lundell <erik.lundell@arm.com> Co-authored-by: Erik Lundell <erik.lundell@arm.com>
PR #14861 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai