Skip to content

Arm backend: build with NAMED_DATA_MAP=ON for vgf #14907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

Arm backend: build with NAMED_DATA_MAP=ON for vgf #14907

merged 1 commit into from
Oct 9, 2025

Conversation

pytorchbot
Copy link
Collaborator

@pytorchbot pytorchbot commented Oct 8, 2025 •
edited by zingo
Loading

PR #14861 and #14899 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@Erik-Lundell @pytorchbot
Arm backend: build with NAMED_DATA_MAP=ON for vgf (#14885)
90a65f9 
PR #14861 introduced the NAMED_DATA_MAP extension which is required to
be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where
needed.

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
(cherry picked from commit 45bf018)
This was referenced Oct 8, 2025
Open
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 8, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14907

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Cancelled Jobs

As of commit 90a65f9 with merge base e0dda90 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2025
@zingo
Copy link
Collaborator

zingo commented Oct 8, 2025

As #14899 got put into the release 1.0 branch this will also be needed and got merged-requested with the same status as it.

@lucylq lucylq mentioned this pull request Oct 9, 2025
Merged
@GregoryComer GregoryComer merged commit 2699488 into release/1.0 Oct 9, 2025
120 of 124 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14885-by-pytorch_bot_bot_ branch October 9, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pytorchbot @zingo @GregoryComer @Erik-Lundell