Enable named data map extension in CUDA build #14898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since #14861 we need to specify `EXECUTORCH_BUILD_EXTENSION_NAMED_DATA_MAP=ON` along with `EXECUTORCH_BUILD_EXTENSION_MODULE=ON`. Adding that.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14898
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 40 PendingAs of commit 07af060 with merge base a9fe0b4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
lucylq
approved these changes
Oct 8, 2025
larryliu0820
added
the
release notes: none
|
If the other cuda work isn't in 1.0, might not need to cherrypick this one either? |
Ah sorry yes that is correct, I don't know whats on 1.0 or not regarding this code, I just spoted you needed to have the same fix in this PR as our backend and it is on 1.0 also. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #14861 we need to specify
EXECUTORCH_BUILD_EXTENSION_NAMED_DATA_MAP=ONalong withEXECUTORCH_BUILD_EXTENSION_MODULE=ON. Adding that to fix CUDA CI.