Skip to content

Conversation

pytorchbot
Copy link
Collaborator

Summary:
Add public merged data map. Module can use this to resolve multiple named data maps.
Creating as a sep dependency rather than inside module/ so it can be used independently of module. (think there may be some other internal usages soon)

Add support for BUCK and CMake. On CMake side, have to add the dep for everyone who uses module ..

Reviewed By: swolchok

Differential Revision: D83527299

Copy link

pytorch-bot bot commented Oct 8, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14899

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 4 Cancelled Jobs

As of commit 7b497d5 with merge base e0dda90 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2025
@GregoryComer
Copy link
Member

Rebasing to see if it fixes build failures.

@GregoryComer GregoryComer force-pushed the cherry-pick-14861-by-pytorch_bot_bot_ branch from 0030422 to 2b553a6 Compare October 8, 2025 19:06
@GregoryComer
Copy link
Member

@lucylq Do you have any recommendations on how to handle the build error? Is there a prerequisite pick that needs to be merged? Thanks.

+ cmake -DCMAKE_INSTALL_PREFIX=cmake-out -DCMAKE_BUILD_TYPE=Release -DEXECUTORCH_ENABLE_LOGGING=ON -DEXECUTORCH_BUILD_EXTENSION_MODULE=ON -DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON -DEXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR=ON -DEXECUTORCH_BUILD_EXTENSION_LLM=ON -DEXECUTORCH_BUILD_EXTENSION_LLM_RUNNER=ON -DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON -DEXECUTORCH_BUILD_KERNELS_LLM=ON -DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON -DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON -DEXECUTORCH_BUILD_XNNPACK=ON -DEXECUTORCH_XNNPACK_SHARED_WORKSPACE=ON -Bcmake-out .
CMake Error at tools/cmake/common/preset.cmake:126 (message):
  Use of 'EXECUTORCH_BUILD_EXTENSION_MODULE' requires
  'EXECUTORCH_BUILD_EXTENSION_NAMED_DATA_MAP'
Call Stack (most recent call first):
  tools/cmake/preset/default.cmake:281 (check_required_options_on)
  CMakeLists.txt:87 (include)

@lucylq
Copy link
Contributor

lucylq commented Oct 9, 2025

@GregoryComer taking a look, I think #14907 needs to be CP'd in as well. Though that seems to be different to test-models-linux-aarch64 ?

GregoryComer pushed a commit that referenced this pull request Oct 9, 2025
PR #14861 and #14899 introduced the NAMED_DATA_MAP extension which is
required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it
on where needed.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Signed-off-by: Erik Lundell <erik.lundell@arm.com>
Co-authored-by: Erik Lundell <erik.lundell@arm.com>
@GregoryComer
Copy link
Member

@GregoryComer taking a look, I think #14907 needs to be CP'd in as well. Though that seems to be different to test-models-linux-aarch64 ?

Thanks. I've merged that pick and will rebase on top. The other failure looks like an infra issue (download failure), so hopefully it will go away on re-run. I'll keep an eye on it.

@GregoryComer GregoryComer force-pushed the cherry-pick-14861-by-pytorch_bot_bot_ branch from 2b553a6 to 56fabec Compare October 9, 2025 22:53
@lucylq
Copy link
Contributor

lucylq commented Oct 9, 2025

@GregoryComer also this one for the llava failure, sorry about that. #14973

Differential Revision: D83527299

Pull Request resolved: #14861

(cherry picked from commit bba9d26)
@GregoryComer GregoryComer force-pushed the cherry-pick-14861-by-pytorch_bot_bot_ branch from 56fabec to 7b497d5 Compare October 10, 2025 22:14
@lucylq
Copy link
Contributor

lucylq commented Oct 11, 2025

Are the macos runner stuck? Seem to be queued for >3hrs

Cancelled and re-running.

@GregoryComer GregoryComer merged commit 54879b8 into release/1.0 Oct 13, 2025
728 of 809 checks passed
@GregoryComer GregoryComer deleted the cherry-pick-14861-by-pytorch_bot_bot_ branch October 13, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants