-
Notifications
You must be signed in to change notification settings - Fork 684
Introduce public MergedDataMap #14899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce public MergedDataMap #14899
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14899
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 Cancelled JobsAs of commit 7b497d5 with merge base e0dda90 ( CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Rebasing to see if it fixes build failures. |
0030422
to
2b553a6
Compare
@lucylq Do you have any recommendations on how to handle the build error? Is there a prerequisite pick that needs to be merged? Thanks.
|
@GregoryComer taking a look, I think #14907 needs to be CP'd in as well. Though that seems to be different to test-models-linux-aarch64 ? |
PR #14861 and #14899 introduced the NAMED_DATA_MAP extension which is required to be on when BUILD_EXTENSION_MODULE is on. Therefore, turn it on where needed. cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai Signed-off-by: Erik Lundell <erik.lundell@arm.com> Co-authored-by: Erik Lundell <erik.lundell@arm.com>
Thanks. I've merged that pick and will rebase on top. The other failure looks like an infra issue (download failure), so hopefully it will go away on re-run. I'll keep an eye on it. |
2b553a6
to
56fabec
Compare
@GregoryComer also this one for the llava failure, sorry about that. #14973 |
56fabec
to
7b497d5
Compare
Are the macos runner stuck? Seem to be queued for >3hrs Cancelled and re-running. |
Summary:
Add public merged data map. Module can use this to resolve multiple named data maps.
Creating as a sep dependency rather than inside module/ so it can be used independently of module. (think there may be some other internal usages soon)
Add support for BUCK and CMake. On CMake side, have to add the dep for everyone who uses module ..
Reviewed By: swolchok
Differential Revision: D83527299