[ET-VK] Rename StorageBuffer to StagingBuffer
#5012
Merged
+53
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Tensors accessible to both CPU and GPU use `StorageBuffer`. 2. Tensors accessible to GPU only use `vTensorStorage`. Since `StorageBuffer` is only used for [staging buffers](https://vulkan-tutorial.com/Vertex_buffers/Staging_buffer), i.e., buffers accessible to both CPU and GPU, `StagingBuffer` is a fitting name for (1) that decreases confusion between (1) and (2). Differential Revision: [D62049779](https://our.internmc.facebook.com/intern/diff/D62049779/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5012
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c22065b with merge base 1263964 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62049779 |
This was referenced Aug 30, 2024
SS-JIA
approved these changes
Aug 30, 2024
1. Tensors accessible to both CPU and GPU use `StorageBuffer`. 2. Tensors accessible to GPU only use `vTensorStorage`. Since `StorageBuffer` is only used for [staging buffers](https://vulkan-tutorial.com/Vertex_buffers/Staging_buffer), i.e., buffers accessible to both CPU and GPU, `StagingBuffer` is a fitting name for (1) that decreases confusion between (1) and (2). Differential Revision: [D62049779](https://our.internmc.facebook.com/intern/diff/D62049779/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62049779 |
junpi3
pushed a commit
that referenced
this pull request
Aug 30, 2024
Pull Request resolved: #5012 1. Tensors accessible to both CPU and GPU use `StorageBuffer`. 2. Tensors accessible to GPU only use `vTensorStorage`. Since `StorageBuffer` is only used for [staging buffers](https://vulkan-tutorial.com/Vertex_buffers/Staging_buffer), i.e., buffers accessible to both CPU and GPU, `StagingBuffer` is a fitting name for (1) that decreases confusion between (1) and (2). ghstack-source-id: 240567145 @exported-using-ghexport Differential Revision: [D62049779](https://our.internmc.facebook.com/intern/diff/D62049779/)
SS-JIA
approved these changes
Aug 30, 2024
1. Tensors accessible to both CPU and GPU use `StorageBuffer`. 2. Tensors accessible to GPU only use `vTensorStorage`. Since `StorageBuffer` is only used for [staging buffers](https://vulkan-tutorial.com/Vertex_buffers/Staging_buffer), i.e., buffers accessible to both CPU and GPU, `StagingBuffer` is a fitting name for (1) that decreases confusion between (1) and (2). Differential Revision: [D62049779](https://our.internmc.facebook.com/intern/diff/D62049779/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62049779 |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5012 1. Tensors accessible to both CPU and GPU use `StorageBuffer`. 2. Tensors accessible to GPU only use `vTensorStorage`. Since `StorageBuffer` is only used for [staging buffers](https://vulkan-tutorial.com/Vertex_buffers/Staging_buffer), i.e., buffers accessible to both CPU and GPU, `StagingBuffer` is a fitting name for (1) that decreases confusion between (1) and (2). ghstack-source-id: 240577434 @exported-using-ghexport Differential Revision: [D62049779](https://our.internmc.facebook.com/intern/diff/D62049779/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
StorageBuffertoStagingBuffer#5012StorageBuffer.vTensorStorage.Since
StorageBufferis only used for staging buffers, i.e., buffers accessible to both CPU and GPU,StagingBufferis a fitting name for (1) that decreases confusion between (1) and (2).Differential Revision: D62049779