[ET-VK] Simplify Allocator's buffer creation methods #5014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 30, 2024 15:08
1. Tensors accessible to both CPU and GPU use `StorageBuffer`. 2. Tensors accessible to GPU only use `vTensorStorage`. Since `StorageBuffer` is only used for [staging buffers](https://vulkan-tutorial.com/Vertex_buffers/Staging_buffer), i.e., buffers accessible to both CPU and GPU, `StagingBuffer` is a fitting name for (1) that decreases confusion between (1) and (2). Differential Revision: [D62049779](https://our.internmc.facebook.com/intern/diff/D62049779/) [ghstack-poisoned]
TSIA Differential Revision: [D62049777](https://our.internmc.facebook.com/intern/diff/D62049777/) [ghstack-poisoned]
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5014
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 5211817 with merge base ef3c53d ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This was referenced Aug 30, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62049778 |
junpi3
pushed a commit
that referenced
this pull request
Aug 30, 2024
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) ghstack-source-id: 240557905 Pull Request resolved: #5014
junpi3
changed the base branch from
gh/jorgep31415/108/base
to
gh/jorgep31415/107/head
SS-JIA
approved these changes
Aug 30, 2024
added 2 commits
August 30, 2024 16:31
…on methods" There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62049778 |
added 2 commits
September 3, 2024 10:19
…on methods" There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62049778 |
added 2 commits
September 3, 2024 10:36
…on methods" There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62049778 |
added 2 commits
September 3, 2024 10:40
…on methods" There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62049778 |
added 2 commits
September 3, 2024 11:30
…on methods" There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D62049778 |
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
Pull Request resolved: pytorch/executorch#5014 There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer. ghstack-source-id: 240831449 @exported-using-ghexport Differential Revision: [D62049778](https://our.internmc.facebook.com/intern/diff/D62049778/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
There are ~4 lines of duplicated code but IMO, the distinct function names make the code much clearer.
Differential Revision: D62049778