Fix dequantize per channel to handle double scale type #5524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

kimishpatel wants to merge 8 commits into gh/kimishpatel/65/base from gh/kimishpatel/65/head

Contributor

kimishpatel commented Sep 20, 2024 •

edited

Loading

Stack from ghstack (oldest at bottom):

Differential Revision: D62301839


          Fix dequantize per channel to handle double scale type

74dad77

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

[ghstack-poisoned]

pytorch-bot bot commented Sep 20, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5524

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 83263cb with merge base d2ba238 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Sep 20, 2024

This pull request was exported from Phabricator. Differential Revision: D62301839

facebook-github-bot added the fb-exported label

This was referenced Sep 20, 2024

[ExecuTorch] Some updated to kv cache #5523

Closed

[ExecuTorch] Add quantized kv cache to llama #5525

Closed

Refactor custom SDPA op to separate kv cache update from the custom sdpa op #5526

Closed

Add update_quantized_cache op #5527

Closed

[Executorch][llama] Update SDPA op to use quantized kv cache #5528

Closed

[Executorch][llama] Refactoring sdpa #5529

Closed

[Executorch] Update EXECUTORCH_LIBRARY macro #5530

Closed

[Executorch][llama] Add custom_sdpa and use that instead of sdpa_with_kv_cache #5531

Closed


          Update on "Fix dequantize per channel to handle double scale type"

9509e6d

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62301839

kimishpatel mentioned this pull request

[Executorch][quant] Optimize per channel dequantize #5596

Closed


          Update on "Fix dequantize per channel to handle double scale type"

99121a0

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Sep 24, 2024

This pull request was exported from Phabricator. Differential Revision: D62301839

This was referenced Sep 24, 2024

[ExecuTorch] Some updated to kv cache #5597

Closed

[ExecuTorch] Add quantized kv cache to llama #5598

Closed

Refactor custom SDPA op to separate kv cache update from the custom sdpa op #5599

Closed

[Executorch][llama] Update SDPA op to use quantized kv cache #5600

Closed

[Executorch][llama] Refactoring sdpa #5601

Closed

[Executorch] Update EXECUTORCH_LIBRARY macro #5602

Closed

[Executorch][llama] Add custom_sdpa and use that instead of sdpa_with_kv_cache #5603

Closed

[Executorch][quant] Optimize per channel dequantize #5604

Closed

swolchok approved these changes

View reviewed changes


          Update on "Fix dequantize per channel to handle double scale type"

c01e703

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D62301839

kimishpatel mentioned this pull request

[ExecuTorch] Some updated to kv cache #5615

Closed

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D62301839

This was referenced Sep 25, 2024

[ExecuTorch] Some updated to kv cache #5649

Closed

[ExecuTorch] Add quantized kv cache to llama #5650

Closed

Refactor custom SDPA op to separate kv cache update from the custom sdpa op #5651

Closed

[Executorch][llama] Update SDPA op to use quantized kv cache #5652

Closed

[Executorch][llama] Refactoring sdpa #5653

Closed

[Executorch] Update EXECUTORCH_LIBRARY macro #5654

Closed

[Executorch][llama] Add custom_sdpa and use that instead of sdpa_with_kv_cache #5655

Closed

[Executorch][quant] Optimize per channel dequantize #5656

Closed


          Update on "Fix dequantize per channel to handle double scale type"

6adc523

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D62301839


          Update on "Fix dequantize per channel to handle double scale type"

83263cb

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

[ghstack-poisoned]

Contributor

facebook-github-bot commented Sep 25, 2024

This pull request was exported from Phabricator. Differential Revision: D62301839

This was referenced Sep 25, 2024

[ExecuTorch] Some updated to kv cache #5663

Closed

[ExecuTorch] Add quantized kv cache to llama #5664

Closed

Refactor custom SDPA op to separate kv cache update from the custom sdpa op #5665

Closed

[Executorch][llama] Update SDPA op to use quantized kv cache #5666

Closed

[Executorch][llama] Refactoring sdpa #5667

Closed

[Executorch] Update EXECUTORCH_LIBRARY macro #5668

Closed

[Executorch][llama] Add custom_sdpa and use that instead of sdpa_with_kv_cache #5669

Closed

[Executorch][quant] Optimize per channel dequantize #5670

Merged

facebook-github-bot closed this in

9d224a5

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Sep 26, 2024

This pull request has been merged in 9d224a5.

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Fix dequantize per channel to handle double scale type

5028fc5

Pull Request resolved: pytorch/executorch#5524


ghstack-source-id: 244449200
@exported-using-ghexport

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Fix dequantize per channel to handle double scale type

cf700d9

Pull Request resolved: pytorch/executorch#5524


ghstack-source-id: 244449200
@exported-using-ghexport

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Fix dequantize per channel to handle double scale type

db76d0d

Pull Request resolved: pytorch/executorch#5524


ghstack-source-id: 244685036
@exported-using-ghexport

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Fix dequantize per channel to handle double scale type

523e9ff

Pull Request resolved: pytorch/executorch#5524


ghstack-source-id: 244449200
@exported-using-ghexport

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request


          Fix dequantize per channel to handle double scale type

fdaa888

Pull Request resolved: pytorch/executorch#5524


ghstack-source-id: 244685036
@exported-using-ghexport

Differential Revision: [D62301839](https://our.internmc.facebook.com/intern/diff/D62301839/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged