[Executorch][llama] Refactoring sdpa

[kimishpatel]

Stack from ghstack (oldest at bottom):

• [Executorch][quant] Optimize per channel dequantize #5596
• [Executorch][llama] Add custom_sdpa and use that instead of sdpa_with_kv_cache #5531
• [Executorch] Update EXECUTORCH_LIBRARY macro #5530
• -> [Executorch][llama] Refactoring sdpa #5529
• [Executorch][llama] Update SDPA op to use quantized kv cache #5528
• Add update_quantized_cache op #5527
• Refactor custom SDPA op to separate kv cache update from the custom sdpa op #5526
• [ExecuTorch] Add quantized kv cache to llama #5525
• Fix dequantize per channel to handle double scale type #5524
• [ExecuTorch] Some updated to kv cache #5523

• Change variable name from is_sdpa_with_kv_cache to is_seq_at_dim_1 to be more meaningful
• remove seq_len as it can be derived from the size of query

Differential Revision: D62623243

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5529

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 27 New Failures

As of commit 13db49d with merge base b2517d6 ():

NEW FAILURES - The following jobs have failed:

• Build documentation / build (buck2) / Build doc (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• Lint / lintrunner / linux-job (gh)
  >>> Lint for kernels/quantized/test/test_quant_dequant_per_token.py:
• pull / test-custom-ops-linux (buck2) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-custom-ops-linux (cmake) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (bf16, buck2, portable) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (bf16, cmake, portable) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (fp32, buck2, portable) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (fp32, buck2, xnnpack+custom) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (fp32, buck2, xnnpack+custom+qe) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (fp32, cmake, portable) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-linux (fp32, cmake, xnnpack+custom+qe) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llama-runner-qnn-linux (fp32, cmake, qnn) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-llava-runner-linux / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-models-linux (buck2, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-models-linux (buck2, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-models-linux (cmake, mv3, portable, linux.2xlarge, 90) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-models-linux (cmake, mv3, xnnpack-quantization-delegation, linux.2xlarge, 90) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-models-linux (cmake, vit, portable, linux.2xlarge, 90) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-models-linux (cmake, vit, xnnpack-delegation, linux.2xlarge, 90) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-pybind-build-linux (cmake) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-quantized-aot-lib-linux (cmake) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-selective-build-linux (buck2) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / test-selective-build-linux (cmake) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / unittest / linux / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]
• pull / unittest / macos / macos-job (gh)
  /Users/ec2-user/runner/_work/executorch/executorch/pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long long' in initializer list [-Wc++11-narrowing]
• pull / unittest-arm (buck2) / linux-job (gh)
  /pytorch/executorch/kernels/quantized/cpu/op_dequantize.cpp:400:42: error: non-constant-expression cannot be narrowed from type 'size_t' (aka 'unsigned long') to 'long' in initializer list [-Wc++11-narrowing]

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62623243

[facebook-github-bot]

This pull request was exported from Phabricator. Differential Revision: D62623243