Dont error check unused tensors in convolution_backward.out #8285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8285
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 65a8efd with merge base 6fb6332 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D69211399 |
facebook-github-bot
added
CLA Signed
manuelcandales
approved these changes
Feb 6, 2025
…8285) Summary: In ATen if this tensor is unused for the functional op it returns an empty tensor. In Executorch we essentially just serialize a place holder to tensor to be passed along, but since the tensor should be unused we dont bother trying to give it robust meta data. In this diff I'm skipping the meta data checks on the tensors if the gradients are unused. Reviewed By: manuelcandales Differential Revision: D69211399
JacobSzwejbka
force-pushed
the
export-D69211399
branch
from
1ffa7ea to
65a8efd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69211399 |
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In ATen if this tensor is unused for the functional op it returns an empty tensor.
In Executorch we essentially just serialize a place holder to tensor to be passed along, but since the tensor should be unused we dont bother trying to give it robust meta data. In this diff I'm skipping the meta data checks on the tensors if the gradients are unused.
Reviewed By: manuelcandales
Differential Revision: D69211399