Skip to content

Dont error check unused tensors in convolution_backward.out #8285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Dont error check unused tensors in convolution_backward.out #8285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions kernels/portable/cpu/op_convolution_backward.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ bool check_convolution_backward_args(
bool transposed,
IntArrayRef output_padding,
int64_t groups,
ET_UNUSED executorch::aten::ArrayRef<bool> output_mask,
executorch::aten::ArrayRef<bool> output_mask,
Tensor& grad_input,
Tensor& grad_weight,
Tensor& grad_bias) {
Expand All @@ -45,9 +45,18 @@ bool check_convolution_backward_args(

ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(weight, input));
ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(grad_output, input));
ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(grad_input, input));
ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(grad_weight, input));
ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(grad_bias, input));

if (output_mask[0]) {
ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(grad_input, input));
}

if (output_mask[1]) {
ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(grad_weight, input));
}

if (output_mask[2]) {
ET_LOG_AND_RETURN_IF_FALSE(tensors_have_same_dtype(grad_bias, input));
}

ET_LOG_MSG_AND_RETURN_IF_FALSE(
check_convolution_args(
Expand Down Expand Up @@ -267,19 +276,23 @@ std::tuple<Tensor&, Tensor&, Tensor&> convolution_backward_out(
InvalidArgument,
ret_val);

ET_KERNEL_CHECK(
ctx,
resize_tensor(grad_input, input.sizes()) == Error::Ok,
InvalidArgument,
ret_val);
if (output_mask[0]) {
ET_KERNEL_CHECK(
ctx,
resize_tensor(grad_input, input.sizes()) == Error::Ok,
InvalidArgument,
ret_val);
}

ET_KERNEL_CHECK(
ctx,
resize_tensor(grad_weight, weight.sizes()) == Error::Ok,
InvalidArgument,
ret_val);
if (output_mask[1]) {
ET_KERNEL_CHECK(
ctx,
resize_tensor(grad_weight, weight.sizes()) == Error::Ok,
InvalidArgument,
ret_val);
}

if (bias_sizes_opt.has_value()) {
if (bias_sizes_opt.has_value() && output_mask[2]) {
ET_KERNEL_CHECK(
ctx,
resize_tensor(grad_bias, bias_sizes_opt.value()) == Error::Ok,
Expand Down
Loading