-
Notifications
You must be signed in to change notification settings - Fork 18
[Profiling] Upload vLLM Profiling results to AWS S3 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you share the S3 folder link? |
@huydhn Can you please share on how can we double check if its good for us, or in future as well, if we are allowed to visit the AWS console. |
I don't think public S3 folders need any console login. However, I'll defer to @huydhn on the access control level here. |
echo "upload-date=${UPLOAD_DATE}" >> "${GITHUB_OUTPUT}" | ||
echo "s3-prefix=${REPOSITORY}/${UPLOAD_DATE}/${HEAD_SHA}" >> "${GITHUB_OUTPUT}" | ||
- name: Upload profiling results to S3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, I can see some profiles on S3, i.e.
- https://gha-artifacts.s3.us-east-1.amazonaws.com/vllm-project/vllm/2025-09-16/cd1f885bcfe3b1731c552495ce70d2abf63d1373/e3746728f887_953.1758048457999122720.pt.trace.json.gz
- https://gha-artifacts.s3.us-east-1.amazonaws.com/vllm-project/vllm/2025-09-16/cd1f885bcfe3b1731c552495ce70d2abf63d1373/e3746728f887_812.async_llm.1758048458161836524.pt.trace.json.gz
Maybe you want to rename these files like 3746728f887_953.1758048457999122720.pt.trace.json.gz
to make it easier to discover them later one, i.e. sglang.pt.trace.json.gz
. IMO, it would be easier to do this on the workflow before the upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed..easy naming would be helpful in future.
I think this is an older commit's url, as I had also added "model_name" in the path, to make it easy for filtering out the data.
This is how it would look with the latest changes: https://gha-artifacts.s3.us-east-1.amazonaws.com/2025-09-17/vllm-project/vllm/ca2d1925ef5ad309061c2d5dd9a1e409c5ca28ee/17788403923/profiling/facebook_opt_125m_tp1_random/vllm.async_llm.pt.trace.json.gz
echo "s3-prefix=${REPOSITORY}/${UPLOAD_DATE}/${HEAD_SHA}" >> "${GITHUB_OUTPUT}" | ||
- name: Upload profiling results to S3 | ||
uses: seemethere/upload-artifact-s3@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another note here is that the upload step, as it stands, only works on AWS runner, linux.aws.a100
or linux.aws.h100
and will not work on linux.dgx.b200
. You can ignore this for now if you don't plan to run anything on b200, but if you do, you will need this snippet https://github.com/pytorch/pytorch/blob/main/.github/workflows/_rocm-test.yml#L105-L111 to configure the credentials before the upload, i.e.
- name: Configure aws credentials
if: contains(env.DEVICE_TYPE, 'B200')
uses: aws-actions/configure-aws-credentials@v4.1.0
with:
role-to-assume: arn:aws:iam::308535385114:role/gha_workflow_s3_and_ecr_read_only
aws-region: us-east-1
role-duration-seconds: 18000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, noted. Right now, I think we are good with using only a100/h100 runners, but if in future, we will change, will add this step. Thanks for sharing.
All artifacts we have on PyTorch OSS CI is public by default. They can be found on |
This is awesome, thank you. |
I have a question: how can I get a directory view of all the traces available for the past 6 months? |
I think there are a couple of ways by which we can see the traces from a directory:
|
This PR includes the following changes:
<date>/<repository>/<commit_sha>/<github_workflow_id>/<github_job_id>
Testing

Github Action: link
Download link for Profiling traces: