-
Notifications
You must be signed in to change notification settings - Fork 18
[Profiling] Upload vLLM Profiling results to AWS S3 #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
093213b
837965c
2fd1df8
fb65db1
8d45ce8
f51ee31
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -214,6 +214,25 @@ jobs: | |
) | ||
docker exec -t "${container_name}" bash -c "cd vllm-profiling && bash ../.github/scripts/run_vllm_profiling.sh" | ||
|
||
- name: Prepare S3 upload metadata | ||
id: prepare_s3_upload | ||
env: | ||
REPOSITORY: vllm-project/vllm | ||
run: | | ||
set -eux | ||
|
||
UPLOAD_DATE=$(date -u +"%Y-%m-%d") | ||
echo "upload-date=${UPLOAD_DATE}" >> "${GITHUB_OUTPUT}" | ||
echo "s3-prefix=${UPLOAD_DATE}/${REPOSITORY}/${HEAD_SHA}/${GITHUB_RUN_ID}/${GITHUB_JOB}" >> "${GITHUB_OUTPUT}" | ||
|
||
- name: Upload profiling results to S3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This works, I can see some profiles on S3, i.e.
Maybe you want to rename these files like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed..easy naming would be helpful in future. |
||
uses: seemethere/upload-artifact-s3@v5 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Another note here is that the upload step, as it stands, only works on AWS runner,
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, noted. Right now, I think we are good with using only a100/h100 runners, but if in future, we will change, will add this step. Thanks for sharing. |
||
with: | ||
s3-prefix: ${{ steps.prepare_s3_upload.outputs.s3-prefix }} | ||
retention-days: 180 | ||
path: vllm-profiling/profiling-results | ||
if-no-files-found: warn | ||
|
||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: profiling-results--${{ env.DEVICE_TYPE }} | ||
|
Uh oh!
There was an error while loading. Please reload this page.