This repository was archived by the owner on Jan 22, 2022. It is now read-only.
Enable a ci/no-build label #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
approved these changes
May 27, 2021
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 27, 2021
Summary: Depends on pytorch/probot#22. Adds a new label called `ci/no-build` that disables the CircleCI `build` workflow on PRs. The current behavior should be the same in the absence of `ci/no-build`. Pull Request resolved: #58778 Reviewed By: malfet Differential Revision: D28615349 Pulled By: samestep fbshipit-source-id: 1ed521761ca4ffa32db954a51918f693beddb3f3
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Depends on pytorch/probot#22. Adds a new label called `ci/no-build` that disables the CircleCI `build` workflow on PRs. The current behavior should be the same in the absence of `ci/no-build`. Specifically, after this PR lands, for anyone who isn't rebased onto the latest `master`, I believe this will happen: - when they push to their PR, the CircleCI app triggers CI - the `pytorch-probot` app sees that their PR doesn't have the `ci/no-build` tag, so it also triggers CI - the latter should auto-cancel the former After checking with #59087, it looks like this would cause the "errored" number to go up and then go down as Circle jobs are canceled (saying "Your CircleCI tests were canceled") and then restarted: <img width="868" alt="Screen Shot 2021-05-27 at 12 39 20 PM" src="https://user-images.githubusercontent.com/8246041/119887123-9667b080-bee8-11eb-8acb-e1967899c9d5.png"> Pull Request resolved: #58778 Reviewed By: malfet Differential Revision: D28995335 Pulled By: samestep fbshipit-source-id: 8d7543b911e4bbbeef14639baf9d9108110b97c8
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Depends on pytorch/probot#22. Adds a new label called `ci/no-build` that disables the CircleCI `build` workflow on PRs. The current behavior should be the same in the absence of `ci/no-build`. Pull Request resolved: pytorch#58778 Reviewed By: malfet Differential Revision: D28615349 Pulled By: samestep fbshipit-source-id: 1ed521761ca4ffa32db954a51918f693beddb3f3
deniskokarev
pushed a commit
to deniskokarev/pytorch
that referenced
this pull request
Jun 9, 2021
Summary: Depends on pytorch/probot#22. Adds a new label called `ci/no-build` that disables the CircleCI `build` workflow on PRs. The current behavior should be the same in the absence of `ci/no-build`. Specifically, after this PR lands, for anyone who isn't rebased onto the latest `master`, I believe this will happen: - when they push to their PR, the CircleCI app triggers CI - the `pytorch-probot` app sees that their PR doesn't have the `ci/no-build` tag, so it also triggers CI - the latter should auto-cancel the former After checking with pytorch#59087, it looks like this would cause the "errored" number to go up and then go down as Circle jobs are canceled (saying "Your CircleCI tests were canceled") and then restarted: <img width="868" alt="Screen Shot 2021-05-27 at 12 39 20 PM" src="https://user-images.githubusercontent.com/8246041/119887123-9667b080-bee8-11eb-8acb-e1967899c9d5.png"> Pull Request resolved: pytorch#58778 Reviewed By: malfet Differential Revision: D28995335 Pulled By: samestep fbshipit-source-id: 8d7543b911e4bbbeef14639baf9d9108110b97c8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables pytorch/pytorch#58778 by adding the follow two features to the syntax of
.github/pytorch-circleci-labels.yml:default_paramssection that applies even when no labels are presentparameterfield is now optional on labels