[C++ API] Fix SGD memory leak when there is weight_decay #23007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Jul 18, 2019
gchanan
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Jul 20, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 21, 2019
Summary: As reported in LaurentMazare/tch-rs#76, the memory grows when weight_decay is present when using Adam. It applies the same fix in #23007 to Adam, Adagrad and RMSProp. Pull Request resolved: #23125 Differential Revision: D16402421 Pulled By: soumith fbshipit-source-id: 59eb4bd81b8bd9e1a5f7c068ed841f70a4c38a80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #20146. I am working on another PR that adds CPU and CUDA memory leak checking to all C++ API tests.