allow INSTALL_TEST to pass through from env to cmake #23793
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
partly fixes #23776 |
ezyang
approved these changes
Aug 5, 2019
There was a problem hiding this comment.
@soumith is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
added a commit
that referenced
this pull request
Aug 5, 2019
Summary: This allows `INSTALL_*` to pass through to cmake. Additional fix is that if `INSTALL_TEST` is specified, it wont use `BUILD_TEST` as the default value for `INSTALL_TEST` Pull Request resolved: #23793 Differential Revision: D16648668 Pulled By: soumith fbshipit-source-id: 52c2a0d8033bc556355b87a6731a577940de9859
xuhdev
added a commit
to xuhdev/pytorch
that referenced
this pull request
Aug 5, 2019
…ke.py. Simplifying pytorch#23793: The dependency relationship between {INSTALL,BUILD}_TEST is already properly handled in CMakeLists.txt. All we need to do is to pass down INSTALL_TEST.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 7, 2019
…ke.py (#23806) Summary: Simplifying #23793: The dependency relationship between {INSTALL,BUILD}_TEST is already properly handled in CMakeLists.txt. All we need to do is to pass down INSTALL_TEST. Pull Request resolved: #23806 Differential Revision: D16691833 Pulled By: soumith fbshipit-source-id: 7607492b2d82db3f79b174373a92e2810a854a61
soumith
pushed a commit
that referenced
this pull request
Aug 7, 2019
…ke.py (#23806) Summary: Simplifying #23793: The dependency relationship between {INSTALL,BUILD}_TEST is already properly handled in CMakeLists.txt. All we need to do is to pass down INSTALL_TEST. Pull Request resolved: #23806 Differential Revision: D16691833 Pulled By: soumith fbshipit-source-id: 7607492b2d82db3f79b174373a92e2810a854a61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
INSTALL_*to pass through to cmake.Additional fix is that if
INSTALL_TESTis specified, it wont useBUILD_TESTas the default value forINSTALL_TEST