Skip to content

Conversation

arktrail
Copy link
Contributor

@arktrail arktrail commented Jul 9, 2020

Summary:
This is a new PR for #40850 and #40987, as I have some issues for rebates for that one. Very sorry about that. And I have fixed the tests failed in that PR.

This diff contains the implementation of C++ API for ParameterList from #25883.
Refer to the Python API:

class ParameterList(Module):

Not sure about some naming difference between C++ API and Python API, like append, should it be called push_back

Test Plan: Add unit tests in this diff

Reviewers: @glaringlee

Subscribers:

Tasks: #25883

Tags:

@glaringlee glaringlee requested review from glaringlee and removed request for ebetica and goldsborough July 9, 2020 21:05
@dr-ci
Copy link

dr-ci bot commented Jul 9, 2020

💊 CI failures summary and remediations

As of commit f9f0eaa (more details on the Dr. CI page):


  • 1/4 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
  • 3/4 broken upstream at merge base 7c29a4e on Jul 09 from 11:32am to 2:18pm PDT (11 commits; f69d6a7 - 1f13514)

🚧 3 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 5 times.

@glaringlee
Copy link
Contributor

@yyn19951228 need a rebase, several CI tests failed.

@arktrail
Copy link
Contributor Author

arktrail commented Jul 10, 2020

@glaringlee
The hard time now, try to have a correct rebase.

@arktrail arktrail closed this Jul 10, 2020
facebook-github-bot pushed a commit that referenced this pull request Jul 13, 2020
Summary:
This is a new PR for #40850, #40987 and #41206 unintentionally closed), as I have some issues for rebates for that one. Very sorry about that. And I have fixed the tests failed in that PR.

This diff contains the implementation of C++ API for ParameterList from #25883.
Refer to the Python API: https://github.com/pytorch/pytorch/blob/bc9e8af21875dafafe9bbd25c8f542b20b2e660f/torch/nn/modules/container.py#L376
Not sure about some naming difference between C++ API and Python API, like `append`, should it be called `push_back`

Pull Request resolved: #41259

Test Plan: Add unit tests in this diff

Differential Revision: D22495780

Pulled By: glaringlee

fbshipit-source-id: 79ea3592db640f35477d445ecdaeafbdad814bec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants