test: Disable test_strided_grad_layout on ROCM #42561
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
seemethere
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
💊 CI failures summary and remediationsAs of commit 4bd4121 (more details on the Dr. CI page):
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
malfet
approved these changes
Aug 4, 2020
|
@seemethere merged this pull request in ccc831a. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 5, 2020
Summary: There were some inconsistencies with the newer docker images so it'd be best to stick with something that works without reverting the entire docker builder PR This was made after the previous efforts to disable the tests that were failing: * #42583 * #42561 Signed-off-by: Eli Uriegas <eliuriegas@fb.com> Pull Request resolved: #42603 Reviewed By: ezyang Differential Revision: D22948743 Pulled By: seemethere fbshipit-source-id: cc8b834e0c8a6a4763f5ba07ce220a9c192ea6eb
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 6, 2020
Summary: Using numpy 1.19.x instead of 1.18.x breaks certain unit tests. Fixes #42561. Likely also fixes #42583. CC ezyang xw285cornell sunway513 Pull Request resolved: #42670 Reviewed By: ezyang Differential Revision: D22978369 Pulled By: malfet fbshipit-source-id: ce1f35c7ba620c2b9dd10613f39354cebee8b87d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Regression was introduced as part of 5939d8a, logs: https://app.circleci.com/pipelines/github/pytorch/pytorch/196558/workflows/9a2dd56e-86af-4d0f-9fb9-b205dcd12f93/jobs/6502042
Going to go ahead and disable the test to give rocm folks time to investigate what's going on
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Differential Revision: D22932615