Skip to content

Add bf16 support to replicate padding #112099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add bf16 support to replicate padding #112099

wants to merge 2 commits into from

Conversation

leng-yue
Copy link
Contributor

Fixes #99433

@pytorch-bot pytorch-bot bot added the release notes: cuda release notes category label Oct 26, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 26, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112099

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 225c947 with merge base 0ed461a (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 26, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

mikaylagawarecki
mikaylagawarecki reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to update the supported dtypes in the opinfo on this line

@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 26, 2023
@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@leng-yue @xuhancn
Add bf16 support to replicate padding (pytorch#112099)
cd0bcdb 
Fixes pytorch#99433

Pull Request resolved: pytorch#112099
Approved by: https://github.com/mikaylagawarecki
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@leng-yue @Skylion007
Add bf16 support to replicate padding (pytorch#112099)
e005844 
Fixes pytorch#99433

Pull Request resolved: pytorch#112099
Approved by: https://github.com/mikaylagawarecki
@shink shink mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cuda release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: "replication_pad1d_cuda" not implemented for 'BFloat16'
4 participants
@leng-yue @mikaylagawarecki @pytorchmergebot @pytorchbot