Skip to content

Reland "Trigger specialization when you call size()/stride() from C++ (#111935)" #112605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Reland "Trigger specialization when you call size()/stride() from C++ (#111935)" #112605

wants to merge 1 commit into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 1, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

This reverts commit 22221c6.

Differential Revision: D50886564

@ezyang ezyang requested a review from Chillee as a code owner November 1, 2023 15:40
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112605

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7c2a287 with merge base 84f59d8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 1, 2023
ezyang added a commit that referenced this pull request Nov 1, 2023
@ezyang
Reland "Trigger specialization when you call size()/stride() from C++ (…
35eec44 
…#111935)"

This reverts commit 22221c6.

ghstack-source-id: 7b1ef00
Pull Request resolved: #112605
@ezyang
Copy link
Contributor Author

ezyang commented Nov 1, 2023

@ezyang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

bdhirsh
bdhirsh reviewed Nov 1, 2023
View reviewed changes
c10/core/TensorImpl.cpp
@@ -635,7 +635,9 @@ bool TensorImpl::is_non_overlapping_and_dense_custom() const {
}

IntArrayRef TensorImpl::sizes_custom() const {
if (C10_UNLIKELY(matches_python_custom(SizesStridesPolicy::CustomSizes))) {
if (C10_UNLIKELY(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one consequence of this is that wrapper tensor subclasses during tracing (like DTensor) will see calls to ‘aten.size’ in their torch_dispatch, and need to handle it properly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only if there are symbolic shapes!

@albanD albanD removed their request for review November 1, 2023 17:27
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 2, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2404/head branch November 5, 2023 15:25
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@ezyang @xuhancn
Reland "Trigger specialization when you call size()/stride() from C++ (…
f43b904 
…pytorch#111935)" (pytorch#112605)

This reverts commit 22221c6.

Differential Revision: [D50886564](https://our.internmc.facebook.com/intern/diff/D50886564)
Pull Request resolved: pytorch#112605
Approved by: https://github.com/voznesenskym
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@ezyang @Skylion007
Reland "Trigger specialization when you call size()/stride() from C++ (…
f3dc4f3 
…pytorch#111935)" (pytorch#112605)

This reverts commit 22221c6.

Differential Revision: [D50886564](https://our.internmc.facebook.com/intern/diff/D50886564)
Pull Request resolved: pytorch#112605
Approved by: https://github.com/voznesenskym
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdhirsh bdhirsh bdhirsh left review comments

@voznesenskym voznesenskym voznesenskym approved these changes

@Chillee Chillee Awaiting requested review from Chillee

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ezyang @facebook-github-bot @pytorchmergebot @voznesenskym @bdhirsh