Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show CUDAExtension example commands as code #112764

Closed
wants to merge 1 commit into from

Conversation

scw
Copy link
Contributor

@scw scw commented Nov 2, 2023

The default rendering of these code snippets renders the TORCH_CUDA_ARCH_LIST values with typographic quotes which prevent the examples from being directly copyable. Use code style for the two extension examples.

Fixes #112763

The default rendering of these code snippets renders the
`TORCH_CUDA_ARCH_LIST` values with typographic quotes which prevent the
examples from being directly copyable. Use code style for the two
extension examples.
Copy link

pytorch-bot bot commented Nov 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112764

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1e7e58a with merge base cce5016 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jbschlosser jbschlosser added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module docathon-h2-2023 Issues for the docathon in H2 2023 labels Nov 2, 2023
@malfet malfet removed the docathon-h2-2023 Issues for the docathon in H2 2023 label Nov 2, 2023
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (waiting for the docs preview build though)

@malfet malfet added release notes: cpp release notes category topic: docs topic category labels Nov 2, 2023
@malfet
Copy link
Contributor

malfet commented Nov 2, 2023

@pytorchbot merge -f "Updatd docs looks fine"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
The default rendering of these code snippets renders the `TORCH_CUDA_ARCH_LIST` values with typographic quotes which prevent the examples from being directly copyable. Use code style for the two extension examples.

Fixes pytorch#112763
Pull Request resolved: pytorch#112764
Approved by: https://github.com/malfet
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
The default rendering of these code snippets renders the `TORCH_CUDA_ARCH_LIST` values with typographic quotes which prevent the examples from being directly copyable. Use code style for the two extension examples.

Fixes pytorch#112763
Pull Request resolved: pytorch#112764
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged open source release notes: cpp release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C++ Extension example has incorrect quoting
5 participants