Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ProcessGroupNCCL] Avoid recording stream for broadcast and scatter #112896

Closed
wants to merge 1 commit into from
Closed

[ProcessGroupNCCL] Avoid recording stream for broadcast and scatter #112896

wants to merge 1 commit into from

Conversation

kwen2501
Copy link
Contributor

@kwen2501 kwen2501 commented Nov 3, 2023

Summary: Follows PR #111431, save memory for DTensor init

Test Plan: Sandcastle

Reviewed By: wanchaol

Differential Revision: D50985365

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 3, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112896

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1f9eba5 with merge base 7b99b3e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: distributed (c10d) release notes category label Nov 3, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50985365

wanchaol
wanchaol approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50985365

kwen2501 added a commit to kwen2501/pytorch that referenced this pull request Nov 6, 2023
@kwen2501 @facebook-github-bot
[ProcessGroupNCCL] Avoid recording stream for broadcast and scatter (p…
516c830 
…ytorch#112896)

Summary:

Follows PR pytorch#111431, save memory for DTensor init

Test Plan: Sandcastle

Reviewed By: wanchaol

Differential Revision: D50985365
@kwen2501 @facebook-github-bot
[ProcessGroupNCCL] Avoid recording stream for broadcast and scatter (p…
1f9eba5 
…ytorch#112896)

Summary:

Follows PR pytorch#111431, save memory for DTensor init

Test Plan: Sandcastle

Reviewed By: wanchaol

Differential Revision: D50985365
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50985365

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
@kwen2501 @Skylion007
[ProcessGroupNCCL] Avoid recording stream for broadcast and scatter (p…
4443b53 
…ytorch#112896)

Summary: Follows PR pytorch#111431, save memory for DTensor init

Test Plan: Sandcastle

Reviewed By: wanchaol

Differential Revision: D50985365

Pull Request resolved: pytorch#112896
Approved by: https://github.com/wanchaol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@fegin fegin Awaiting requested review from fegin

@fduwjj fduwjj Awaiting requested review from fduwjj

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

@wz337 wz337 Awaiting requested review from wz337

@LucasLLC LucasLLC Awaiting requested review from LucasLLC

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: distributed (c10d) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kwen2501 @facebook-github-bot @pytorchmergebot @wanchaol