New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not generate zero-numel NT by default in helper and improve to_padded_tensor msg #113162
Conversation
…ded_tensor msg [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113162
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cdbb34c with merge base 1855153 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ded_tensor msg ghstack-source-id: 53b61ff106d3fbee31853a32d06b0f3599fc5a61 Pull Request resolved: #113162
…rove to_padded_tensor msg" [ghstack-poisoned]
…ded_tensor msg ghstack-source-id: 59eb7192f42b057db40af48e1cb79a5f5818a3f3 Pull Request resolved: #113162
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
I think we should avoid a non-deterministic length loop if possible, but it's probably not that big of a deal
…rove to_padded_tensor msg" [ghstack-poisoned]
…ded_tensor msg ghstack-source-id: 0d0181ba58b23e85b07271fb2afdbbecb893de43 Pull Request resolved: #113162
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…ded_tensor msg (pytorch#113162) Improvements: improves to_padded_tensor error message when passed a NT with zero numel Pull Request resolved: pytorch#113162 Approved by: https://github.com/jbschlosser ghstack dependencies: pytorch#113031, pytorch#112519, pytorch#113091
Stack from ghstack (oldest at bottom):
Improvements: improves to_padded_tensor error message when passed a NT with zero numel