[fx] stylistic improvements for fx.split_module #113373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113373
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1342d5a with merge base 1d56e7b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
[ghstack-poisoned]
jon-chuang
added
topic: not user facing
wconstab
approved these changes
Nov 9, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jon-chuang
added a commit
to jon-chuang/pytorch
that referenced
this pull request
Nov 11, 2023
ghstack-source-id: 2fbd8f2758ffbf1e13d3d794244f028598090cde Pull Request resolved: pytorch#113373
Skylion007
pushed a commit
to Skylion007/pytorch
that referenced
this pull request
Nov 14, 2023
Was overly verbose before. Less qualified / long names = more clarity Pull Request resolved: pytorch#113373 Approved by: https://github.com/wconstab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Was overly verbose before. Less qualified / long names = more clarity