[BE]: Add better handling of pathlib.Path with os calls #116564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116564
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 27d8cea with merge base 5aa258e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
force-pushed
the
skylion007/update-torch-serialization-fspath-2023-12-30-v2
branch
from
4411f59 to
e156855
Compare
Skylion007
added
the
better-engineering
Skylion007
force-pushed
the
skylion007/update-torch-serialization-fspath-2023-12-30-v2
branch
from
e156855 to
094ffa0
Compare
Skylion007
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
Skylion007
force-pushed
the
skylion007/update-torch-serialization-fspath-2023-12-30-v2
branch
from
094ffa0 to
531fc1c
Compare
malfet
approved these changes
Dec 30, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 31, 2023
Follow up #116564. `os.path` functions can accept an os.PathLike object too. Pull Request resolved: #116577 Approved by: https://github.com/malfet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #116562 to the rest of the instances of pathlib in the PyTorch.
os.PathLikeandos.fspathcalls where appropiate