Skip to content

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Mar 18, 2024

The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead.

Copy link

pytorch-bot bot commented Mar 18, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122064

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (3 Unrelated Failures)

As of commit 057cf7a with merge base 7360287 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever marked this pull request as draft March 18, 2024 01:28
@cyyever cyyever force-pushed the remove_array branch 4 times, most recently from 145d2ab to 8ee3fa8 Compare March 18, 2024 03:35
@cyyever cyyever marked this pull request as ready for review March 18, 2024 03:58
@cyyever cyyever force-pushed the remove_array branch 4 times, most recently from b7da18d to edfee5e Compare March 18, 2024 07:33
@cyyever cyyever changed the title Remove inclusion of ATen/core/Array.h [1/N] Remove inclusion of ATen/core/Array.h Mar 18, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Mar 18, 2024

@pytorchbot label ciflow/binaries

@pytorch-bot pytorch-bot bot added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Mar 18, 2024
@bdhirsh bdhirsh requested a review from ezyang March 18, 2024 21:51
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 18, 2024
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember why Array.h was added in the first place? c++17 backport?

@cyyever
Copy link
Collaborator Author

cyyever commented Mar 19, 2024

Do you remember why Array.h was added in the first place? c++17 backport?

I don't know, but I guess it is before C++14 was adopted?

@cyyever
Copy link
Collaborator Author

cyyever commented Mar 19, 2024

@pytorchbot label ciflow/binaries

@cyyever cyyever added topic: not user facing topic category ciflow/trunk Trigger trunk jobs on your pull request labels Mar 19, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Mar 19, 2024

@ezyang CUDA 12.1 ptx keeps crashing after these changes. It seems that we have to delay the merge.

Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label May 18, 2024
@cyyever cyyever added no-stale and removed Stale labels May 18, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Aug 21, 2024

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased remove_array onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout remove_array && git pull --rebase)

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 18, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Nov 18, 2024

@pytorchmergebot merge -f "Fix transitive inclusion"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 22, 2024
youssef62 pushed a commit to youssef62/pytorch that referenced this pull request Nov 23, 2024
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead.

Pull Request resolved: pytorch#122064
Approved by: https://github.com/ezyang
youssef62 pushed a commit to youssef62/pytorch that referenced this pull request Nov 23, 2024
This reverts commit 486b9aa.

Reverted pytorch#122064 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but lots of compilation errors show up after this lands ([comment](pytorch#122064 (comment)))
youssef62 pushed a commit to youssef62/pytorch that referenced this pull request Nov 23, 2024
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead.

Pull Request resolved: pytorch#122064
Approved by: https://github.com/ezyang
youssef62 pushed a commit to youssef62/pytorch that referenced this pull request Nov 23, 2024
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead.

Pull Request resolved: pytorch#122064
Approved by: https://github.com/ezyang
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
This reverts commit 486b9aa.

Reverted pytorch#122064 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but lots of compilation errors show up after this lands ([comment](pytorch#122064 (comment)))
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead.

Pull Request resolved: pytorch#122064
Approved by: https://github.com/ezyang
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged no-stale open source Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants