-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[1/N] Remove inclusion of ATen/core/Array.h #122064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122064
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
✅ You can merge normally! (3 Unrelated Failures)As of commit 057cf7a with merge base 7360287 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
145d2ab
to
8ee3fa8
Compare
b7da18d
to
edfee5e
Compare
@pytorchbot label ciflow/binaries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember why Array.h was added in the first place? c++17 backport?
I don't know, but I guess it is before C++14 was adopted? |
@pytorchbot label ciflow/binaries |
@ezyang CUDA 12.1 ptx keeps crashing after these changes. It seems that we have to delay the merge. |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
@pytorchbot rebase |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
@pytorchmergebot merge -f "Fix transitive inclusion" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Follows #122064 Pull Request resolved: #141205 Approved by: https://github.com/ezyang
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead. Pull Request resolved: pytorch#122064 Approved by: https://github.com/ezyang
This reverts commit 486b9aa. Reverted pytorch#122064 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but lots of compilation errors show up after this lands ([comment](pytorch#122064 (comment)))
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead. Pull Request resolved: pytorch#122064 Approved by: https://github.com/ezyang
Follows pytorch#122064 Pull Request resolved: pytorch#141205 Approved by: https://github.com/ezyang
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead. Pull Request resolved: pytorch#122064 Approved by: https://github.com/ezyang
This reverts commit 486b9aa. Reverted pytorch#122064 on behalf of https://github.com/huydhn due to Sorry for reverting your change, but lots of compilation errors show up after this lands ([comment](pytorch#122064 (comment)))
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead. Pull Request resolved: pytorch#122064 Approved by: https://github.com/ezyang
Follows pytorch#122064 Pull Request resolved: pytorch#141205 Approved by: https://github.com/ezyang
The functionality of Array.h is largely overlapped with std::array and it should be safe to use std::array instead.