Skip to content

[2/N] Replace at::detail::Array with std::array #141205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[2/N] Replace at::detail::Array with std::array #141205

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Nov 21, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141205

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit f4f2100 with merge base cd942d0 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever changed the title Use std::array [2/N] Remove inclusion of ATen/core/Array.h Nov 21, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Nov 21, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 21, 2024
@cyyever cyyever added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 21, 2024
@cyyever cyyever requested a review from ezyang November 21, 2024 04:57
@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2024
@cyyever cyyever changed the title [2/N] Remove inclusion of ATen/core/Array.h [2/N] Replace at::detail::Array with std::array Nov 21, 2024
@ezyang
Copy link
Contributor

ezyang commented Nov 22, 2024

@pytorchbot merge

@cyyever
Copy link
Collaborator Author

cyyever commented Nov 22, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

youssef62 pushed a commit to youssef62/pytorch that referenced this pull request Nov 23, 2024
@cyyever @youssef62
[2/N] Replace at::detail::Array with std::array (pytorch#141205)
013d9c8 
Follows pytorch#122064

Pull Request resolved: pytorch#141205
Approved by: https://github.com/ezyang
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@cyyever
[2/N] Replace at::detail::Array with std::array (pytorch#141205)
d6bcb7e 
Follows pytorch#122064

Pull Request resolved: pytorch#141205
Approved by: https://github.com/ezyang
@cyyever cyyever deleted the use_array_cyy branch December 22, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@eqy eqy Awaiting requested review from eqy eqy is a code owner

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed syed-ahmed is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: jit Add this issue/PR to JIT oncall triage queue open source topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @ezyang @pytorchmergebot @pytorchbot