Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate some C++11 checks #126308

Closed
wants to merge 1 commit into from
Closed

Conversation

r-barnes
Copy link
Contributor

Test Plan: Sandcastle

Reviewed By: palmje

Differential Revision: D57246912

Copy link

pytorch-bot bot commented May 15, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126308

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit f965842 with merge base 91bf952 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57246912

@r-barnes r-barnes changed the title Remove unused variables from fbcode/mastermind/lefdef/PrimeTime.cpp Eliminate some C++11 checks May 16, 2024
@r-barnes r-barnes added release notes: cpp release notes category topic: improvements topic category topic: not user facing topic category labels May 16, 2024
@r-barnes r-barnes requested a review from Skylion007 May 16, 2024 14:15
…ytorch#126308)

Summary: Pull Request resolved: pytorch#126308

Test Plan: Sandcastle

Reviewed By: palmje

Differential Revision: D57246912
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57246912

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 16, 2024
@r-barnes
Copy link
Contributor Author

@pytorcbot merge -i

@r-barnes
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@r-barnes r-barnes deleted the export-D57246912 branch May 16, 2024 22:43
ZelboK pushed a commit to ZelboK/pytorch that referenced this pull request May 19, 2024
Test Plan: Sandcastle

Reviewed By: palmje

Differential Revision: D57246912

Pull Request resolved: pytorch#126308
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: cpp release notes category topic: improvements topic category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants