Skip to content

Conversation

ZainRizvi
Copy link
Contributor

@ZainRizvi ZainRizvi commented May 30, 2024

Part of moving pytorch/pytorch CI infra to a Linux foundation run AWS account.

For self-hosted runners that can run jobs from just a single repo, the runner scalers expect them to be stored in the repo itself.

These scale-config files define how the linux foundation's self-hosted runners are configured. These will apply to runners that only are available to the pytorch/pytorch and pytorch/pytorch-canary repos

Copy link

pytorch-bot bot commented May 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127566

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 5310478 with merge base 18a3f78 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 30, 2024
@ZainRizvi ZainRizvi marked this pull request as ready for review May 30, 2024 20:32
@ZainRizvi ZainRizvi requested a review from a team as a code owner May 30, 2024 20:32
@ZainRizvi ZainRizvi requested a review from zxiiro May 30, 2024 20:32
@ZainRizvi
Copy link
Contributor Author

@pytorchbot merge -f "lint passed. Other jobs are irrelevant"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • OSS CI (alband, dagitses, pytorch/pytorch-dev-infra)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess we have decided to keep the scale config here?

@ZainRizvi
Copy link
Contributor Author

LGTM! I guess we have decided to keep the scale config here?

At least for now. This is how the pre-existing code expects per-repo level runners to be configured. A config in test-infra is expected for org-wide runners

@ZainRizvi
Copy link
Contributor Author

@pytorchbot merge -f "lint passed. Other jobs are irrelevant"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request May 31, 2024
…127578)

Initial set of runners added in #127566 seem to be working.

Expanding to include more machine types, especially GPU machines
Pull Request resolved: #127578
Approved by: https://github.com/huydhn
petrex pushed a commit to petrex/pytorch that referenced this pull request Jun 5, 2024
Part of moving pytorch/pytorch CI infra to a Linux foundation run AWS account.

For self-hosted runners that can run jobs from just a single repo, the runner scalers expect them to be stored in the repo itself.

These scale-config files define how the linux foundation's self-hosted runners are configured. These will apply to runners that only are available to the pytorch/pytorch and pytorch/pytorch-canary repos
Pull Request resolved: pytorch#127566
Approved by: https://github.com/zxiiro, https://github.com/huydhn, https://github.com/atalman
petrex pushed a commit to petrex/pytorch that referenced this pull request Jun 5, 2024
…ytorch#127578)

Initial set of runners added in pytorch#127566 seem to be working.

Expanding to include more machine types, especially GPU machines
Pull Request resolved: pytorch#127578
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the zainr/lf-scale-configs branch July 1, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants