Skip to content

Expand supported labels to most self-hosted linux pull.yml workflows #127578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Expand supported labels to most self-hosted linux pull.yml workflows #127578

wants to merge 2 commits into from

Conversation

ZainRizvi
Copy link
Contributor

@ZainRizvi ZainRizvi commented May 30, 2024 •
edited
Loading

Initial set of runners added in #127566 seem to be working.

Expanding to include more machine types, especially GPU machines

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 30, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 30, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127578

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 6657757 with merge base e02971f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ZainRizvi ZainRizvi marked this pull request as ready for review May 30, 2024 22:27
@ZainRizvi ZainRizvi requested a review from a team as a code owner May 30, 2024 22:27
@ZainRizvi
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 31, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@ZainRizvi
Copy link
Contributor Author

@pytorchbot merge -f "lint passed. Others are irrelevant"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@ZainRizvi ZainRizvi mentioned this pull request May 31, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request May 31, 2024
@ZainRizvi @pytorchmergebot
[EZ] Port over all test-infra scale configs to lf runners (#127645)
02248b7 
Follow up to #127578

Since GPU builds seem to be working correctly, porting over all remaining scale configs from [the org-wide scale config file](https://github.com/pytorch/test-infra/blob/main/.github/scale-config.yml)

The naming convention here is all temporary. We'll figure out something better before completing the migration
Pull Request resolved: #127645
Approved by: https://github.com/malfet
petrex pushed a commit to petrex/pytorch that referenced this pull request Jun 5, 2024
@ZainRizvi
Expand supported labels to most self-hosted linux pull.yml workflows (p…
fa72d42 
…ytorch#127578)

Initial set of runners added in pytorch#127566 seem to be working.

Expanding to include more machine types, especially GPU machines
Pull Request resolved: pytorch#127578
Approved by: https://github.com/huydhn
petrex pushed a commit to petrex/pytorch that referenced this pull request Jun 5, 2024
@ZainRizvi
[EZ] Port over all test-infra scale configs to lf runners (pytorch#12…
74454dc 
…7645)

Follow up to pytorch#127578

Since GPU builds seem to be working correctly, porting over all remaining scale configs from [the org-wide scale config file](https://github.com/pytorch/test-infra/blob/main/.github/scale-config.yml)

The naming convention here is all temporary. We'll figure out something better before completing the migration
Pull Request resolved: pytorch#127645
Approved by: https://github.com/malfet
@github-actions github-actions bot deleted the zainr/more-lf-configs branch July 1, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZainRizvi @pytorchmergebot @huydhn