-
Notifications
You must be signed in to change notification settings - Fork 25k
[PT2][Observability] Change the log logic #129201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was exported from Phabricator. Differential Revision: D58854330 |
Summary: Pull Request resolved: pytorch#129201 We only log the multiplier when users changes the default value. Test Plan: see signal Reviewed By: dshi7 Differential Revision: D58854330
ae3c07a
to
65eccf6
Compare
This pull request was exported from Phabricator. Differential Revision: D58854330 |
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: We only log the multiplier when users changes the default value.
Test Plan: see signal
Differential Revision: D58854330
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang