Skip to content

[4/N] Fix clang-tidy warnings in aten/src/ATen/native/ #132001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[4/N] Fix clang-tidy warnings in aten/src/ATen/native/ #132001

wants to merge 1 commit into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Jul 28, 2024 •
edited
Loading

Follows #132000

@cyyever cyyever requested review from kulinseth and malfet as code owners July 28, 2024 08:47
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 28, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132001

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b96da2b with merge base 7be0ce5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jul 28, 2024
@cyyever cyyever marked this pull request as draft July 28, 2024 08:47
@cyyever cyyever changed the title Fix clang-tidy warnings [4/N] Fix clang-tidy warnings in aten/src/ATen/native/ Aug 2, 2024
@cyyever cyyever marked this pull request as ready for review August 2, 2024 14:56
@cyyever cyyever added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 2, 2024
@cyyever cyyever requested a review from ezyang August 2, 2024 15:06
@Skylion007
Copy link
Collaborator

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever mentioned this pull request Aug 3, 2024
Closed
pytorchmergebot pushed a commit that referenced this pull request Aug 4, 2024
@cyyever @pytorchmergebot
[5/N] Fix clang-tidy warnings in aten/src/ATen (#132565)
105ba7b 
Follows #132001

Pull Request resolved: #132565
Approved by: https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth kulinseth is a code owner

@malfet malfet Awaiting requested review from malfet malfet is a code owner

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @Skylion007 @pytorchmergebot @pytorchbot