Skip to content

Fix calling Add._from_args and Mul._from_args #136143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Fix calling Add._from_args and Mul._from_args #136143

wants to merge 6 commits into from

Conversation

isuruf
Copy link
Collaborator

@isuruf isuruf commented Sep 16, 2024 •
edited
Loading

@isuruf
Update
795f548 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136143

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2c14697 with merge base d2207c5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Sep 16, 2024
@isuruf
Update
7122310 
[ghstack-poisoned]
Skylion007
Skylion007 reviewed Sep 16, 2024
View reviewed changes
torch/fx/experimental/symbolic_shapes.py Outdated

# we don't support non commutative with sort
assert is_commutative is True
args = list(args)
Copy link
Collaborator

@Skylion007 Skylion007 Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: args should already be a list or there is a Typing error lol

@isuruf
Update
bd8cd1b 
[ghstack-poisoned]
@isuruf
Update
b7ab7be 
[ghstack-poisoned]
@isuruf
Update
7960211 
[ghstack-poisoned]
@isuruf
Update
2c14697 
[ghstack-poisoned]
isuruf added a commit that referenced this pull request Sep 16, 2024
@isuruf
Fix calling Add._from_args and Mul._from_args
dd05b37 
ghstack-source-id: 88df631
Pull Request resolved: #136143
@isuruf isuruf requested a review from ezyang September 17, 2024 20:33
ezyang
ezyang approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you finding these? Do we need more tests for internal sympy invariants?

@isuruf
Copy link
Collaborator Author

isuruf commented Sep 18, 2024

How are you finding these? Do we need more tests for internal sympy invariants?

After #136079, I realized that _from_args does less things than I thought it did. Just read all the PRs where I added _from_args, to make sure I didn't have any assumptions.

@isuruf
Copy link
Collaborator Author

isuruf commented Sep 18, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 18, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
@isuruf @Chao1Han
Fix calling Add._from_args and Mul._from_args (pytorch#136143)
01db0e8 
Pull Request resolved: pytorch#136143
Approved by: https://github.com/ezyang
isuruf added a commit to isuruf/pytorch that referenced this pull request Sep 23, 2024
@isuruf
Fix calling Add._from_args and Mul._from_args
e49221a 
ghstack-source-id: 0ebce2a
Pull Request resolved: pytorch#136143
isuruf added a commit to isuruf/pytorch that referenced this pull request Sep 23, 2024
@isuruf
Fix calling Add._from_args and Mul._from_args
2f9c7f7 
ghstack-source-id: 88df631
Pull Request resolved: pytorch#136143
@github-actions github-actions bot deleted the gh/isuruf/91/head branch October 19, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 left review comments

@ezyang ezyang ezyang approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@isuruf @pytorchmergebot @ezyang @Skylion007 @pytorchbot