Skip to content

[3/N] Fix clang-tidy warnings in torch/csrc/lazy #136705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[3/N] Fix clang-tidy warnings in torch/csrc/lazy #136705

wants to merge 2 commits into from

Conversation

cyyever
Copy link
Collaborator

@cyyever cyyever commented Sep 26, 2024 •
edited
Loading

Follows #136634

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/136705

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 522fcc2 with merge base e8f1dd6 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@cyyever cyyever changed the title Lazy tidy4 [3/N] Fix clang-tidy warnings in torch/csrc/lazy Sep 26, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 26, 2024

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 26, 2024
@cyyever cyyever added module: lazy release notes: lazy release notes category labels Sep 26, 2024
@cyyever
Copy link
Collaborator Author

cyyever commented Sep 26, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 26, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm6.2-py3.10 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Collaborator Author

cyyever commented Sep 26, 2024

@pytorchbot merge -f "unrelated ROCm failures "

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit to sanchitintel/pytorch that referenced this pull request Sep 26, 2024
@cyyever @pytorchmergebot
[3/N] Fix clang-tidy warnings in torch/csrc/lazy (pytorch#136705)
ef47f9f 
Follows pytorch#136634
Pull Request resolved: pytorch#136705
Approved by: https://github.com/Skylion007
@cyyever cyyever deleted the lazy_tidy4 branch September 27, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: lazy open source release notes: lazy release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyyever @pytorchmergebot @Skylion007 @pytorchbot