-
Notifications
You must be signed in to change notification settings - Fork 25.3k
inductor.config.descriptive_names = False is not actually supported (#145523) (#145523) #146051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ytorch#145523) (pytorch#145523) Summary: This config is not supported (it throws an error when set), and doesn't really make sense imo. Approved by: https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82 Differential Revision: D68846308
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/146051
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 8ffe98c with merge base 7796e30 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D68846308 |
@pytorchbot merge |
Merge failedReason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR! Details for Dev Infra teamRaised by workflow job |
This pull request was exported from Phabricator. Differential Revision: D68846308 |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
…145523) (#146051) Summary: This config is not supported (it throws an error when set), and doesn't really make sense imo. Approved by: https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82 Reviewed By: masnesral Differential Revision: D68846308
…145523) (#146051) (#151481) Summary: This config is not supported (it throws an error when set), and doesn't really make sense imo. Approved by: https://github.com/eellison Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82 Reviewed By: masnesral Differential Revision: D68846308 Pull Request resolved: #151481 Approved by: https://github.com/masnesral
…ported (#145523) (#146051) (#151481)" This reverts commit cfc4d74. Reverted #151481 on behalf of https://github.com/malfet due to It indeed breaks lint, it followup PR contains it's own issues ([comment](#151481 (comment)))
Summary:
This config is not supported (it throws an error when set), and doesn't really make sense imo.
Approved by: https://github.com/eellison
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/edf266e9bbbf6063f7c4a336ffb50234e11a0a82
Differential Revision: D68846308
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov