Fix 32-bit indexing overflows in ReducedPrecisionGemV #150949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150949
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b1f6dbb with merge base cc185c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: cpu
Skylion007
reviewed
Apr 10, 2025
Skylion007
approved these changes
Apr 10, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
timocafe
pushed a commit
to timocafe/pytorch
that referenced
this pull request
Apr 16, 2025
By chaining `lda` type from `int` to ~~`long`~~ `int64_t` Add regression test (but probably restrict it to CPUs (or may be skip float32 testing on GPUs) Fixes pytorch#150637 Pull Request resolved: pytorch#150949 Approved by: https://github.com/Skylion007
amathewc
pushed a commit
to amathewc/pytorch
that referenced
this pull request
Apr 17, 2025
By chaining `lda` type from `int` to ~~`long`~~ `int64_t` Add regression test (but probably restrict it to CPUs (or may be skip float32 testing on GPUs) Fixes pytorch#150637 Pull Request resolved: pytorch#150949 Approved by: https://github.com/Skylion007
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 28, 2025
…lambda arguments as int64_t (#152233) This plus the previous irangeification PR seem like a better fix for #150637 than #150949 to me -- should make sure we are using 64-bit math for indexing everywhere. Pull Request resolved: #152233 Approved by: https://github.com/Skylion007, https://github.com/cyyever ghstack dependencies: #152232
pytorchmergebot
pushed a commit
to toyxu/pytorch
that referenced
this pull request
Apr 28, 2025
…lambda arguments as int64_t (pytorch#152233) This plus the previous irangeification PR seem like a better fix for pytorch#150637 than pytorch#150949 to me -- should make sure we are using 64-bit math for indexing everywhere. Pull Request resolved: pytorch#152233 Approved by: https://github.com/Skylion007, https://github.com/cyyever ghstack dependencies: pytorch#152232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
By chaining
ldatype frominttolongint64_tAdd regression test (but probably restrict it to CPUs (or may be skip float32 testing on GPUs)
Fixes #150637
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10